-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@charset "UTF-8" moved below @import #436
Comments
I'm not understanding the issue here; the input css does not contain |
@RyanZim I messed up the markdown. Fixed now. |
Oof, yeah, that's a bug; investigating... |
PR with a failing test to replicate this bug: #438. I've made some progress tracking down why this happens, but still haven't figured out the right way to fix it. Feel free to take a stab at it yourself, BTW, otherwise, I'll keep working on this as I get time. |
There is probably no right answer on how to handle charset since you could theoretically find them anywhere in the root file, or imported files, but at the end of the day there needs to be at most one. Looks like all files that get @imported in get brought in as utf-8, but the root passed in css file contents could be any encoding, so it may not be safe to assume that everything could have @charset "UTF-8" slapped at the top. |
OK, got a half-decent solution here: #447 Take a look, and let me know what you think. |
Previously opened an issue with angular, but I've isolated the issue to this library.
The incoming css looks like
but after passing through this plugin, the @import is listed above the @charset. @charset needs to be listed first to work.
Thanks!
The text was updated successfully, but these errors were encountered: