Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e-tests: unskip problems test #6792

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

e2e-tests: unskip problems test #6792

wants to merge 1 commit into from

Conversation

midleman
Copy link
Contributor

@midleman midleman commented Mar 14, 2025 •
edited
Loading

Summary

Turning the e2e problems tests back on.

QA Notes

@:web @:win @:problems

@midleman midleman requested a review from jonvanausdeln March 14, 2025 21:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:web @:win @:problems

readme  valid tags

@midleman midleman requested a review from testlabauto March 14, 2025 21:04
@midleman midleman marked this pull request as ready for review March 14, 2025 21:04
jonvanausdeln
jonvanausdeln approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@jonvanausdeln jonvanausdeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

testlabauto
testlabauto approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Might want to remove the annotation

@testlabauto
Copy link
Contributor

LGTM! Might want to remove the annotation

Did you forget to tag @:problems?

@midleman
Copy link
Contributor Author

LGTM! Might want to remove the annotation

Did you forget to tag @:problems?

D'oh. I did. 😆

@midleman
Copy link
Contributor Author

LGTM! Might want to remove the annotation

There were 2 annotations. I removed the issue that has been closed, but left the open one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonvanausdeln jonvanausdeln jonvanausdeln approved these changes

@testlabauto testlabauto testlabauto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@midleman @testlabauto @jonvanausdeln