Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiments fully enabled by the TAS server are not enabled in Positron #3465

Open
seeM opened this issue Jun 10, 2024 · 1 comment
Open
Labels
area: core Issues related to Core category. bug Something isn't working
Milestone

Comments

@seeM
Copy link
Contributor

seeM commented Jun 10, 2024

VSCode allows A/B experiments in extensions via the vscode-tas-client package. Some experiments are enabled for all users on the TAS server but disabled by default in the client code.

One example is the pythonTestAdapter experiment in the Python extension, which enables a full rewrite of test-related functionality. See microsoft/vscode-python#17242 for a full list of the improvements. I don't believe the legacy test adapter has seen updates so we're effectively running unmaintained code.

Here's a tiny example, I'm sure there are worse side-effects. The legacy test adapter doesn't support colorized outputs:

Legacy:

image

Rewrite:

image

There may be other extensions running into a similar issue. I can think of two ways to deal with this:

  1. Let each extension deal with it separately, and enable any required experiments as needed.
  2. Override the module loader to patch vscode-tas-client to always return a "no-op" experimentation service that operates from a hard-coded list of enabled/disabled experiments (it could extend the TelemetryDisabledExperimentationService).
  3. Host our own TAS server and configure vscode-tas-client to use that.
@seeM seeM added the bug Something isn't working label Jun 10, 2024
@juliasilge juliasilge added the area: core Issues related to Core category. label Jun 10, 2024
@juliasilge juliasilge added this to the Release Candidate milestone Jun 11, 2024
@seeM
Copy link
Contributor Author

seeM commented Jun 12, 2024

For reference, here are the Python extension experiments I currently see enabled by the TAS server in VSCode:

2024-05-31 17:18:12.912 [info] Experiment 'pythonCreateEnvOnPipInstall' is active
2024-05-31 17:18:12.912 [info] Experiment 'pythonRecommendTensorboardExt' is active
2024-05-31 17:18:12.912 [info] Experiment 'pythonTerminalEnvVarActivation' is active
2024-05-31 17:18:12.912 [info] Experiment 'pythonTestAdapter' is active

@jmcphers jmcphers modified the milestones: Release Candidate, Future Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues related to Core category. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants