Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store reason for start and end of membership #20

Closed
evdb opened this issue Mar 1, 2013 · 6 comments
Closed

Store reason for start and end of membership #20

evdb opened this issue Mar 1, 2013 · 6 comments

Comments

@evdb
Copy link

evdb commented Mar 1, 2013

This is used in the TWFY codebase to describe the situation in which a representative starts and stops their tenure - see instances in the codebase and a list of example reasons

They should be optional. The keys start_reason and end_reason could be used and the values be plain strings.

@jpmckinney jpmckinney mentioned this issue Mar 1, 2013
@jpmckinney
Copy link
Member

This is a provenance question. The PROV-O vocabulary has classes and properties for describing change events in more detail. I'd want to investigate that existing standard before minting new terms. You can help by having a look yourself :)

@evdb
Copy link
Author

evdb commented Mar 1, 2013

Perhaps I'm missing something but there does not seem to be anything in the PROV_O spec that is applicable. They would link a start to other classes in the ontology, rather than a simple textual description. The closest thing would be wasStartedBy property (and the related wasEndedBy).

@jpmckinney
Copy link
Member

Actually, changeEvent is part of ORG but it's only for changes to organizations. It may however point to how to use PROV for similar events. Anyway, it's important to base standards on existing standards, otherwise it becomes a game of "my standard versus your standard." It's much better for the situation to be "it's your standard versus my standard plus the dozen standards my standard is based on" as is the case with Popolo currently.

@jpmckinney
Copy link
Member

Also, PROV-O may not have the single property you want. For the JSON/MongoDB serialization, we can maybe simplify whatever it has to one property. But it's first important to understand how they do things and why they do it that way.

@jpmckinney
Copy link
Member

As with #18, I am increasingly of the opinion that the only sane approach is to have an Event class. The Event class should have some type mechanism, whether as a property or by subclassing the event class, to account for all the event types in TWFY.

The membership could reference an Event class with respect to its start and end dates. How does that sound? In this case, we can indeed inspire a lot from how ORG uses PROV-O. We can move the dates out of Membership entirely, but I think many use cases won't have anything on the Event besides the date, and so it's best to leave a mechanism for people who don't need full-fledged events (sort of like how Posts are optional).

It should have occurred to me earlier, but when we talk about making a property like a date into an object, that usually means making that property into a class with its own properties - thus Event. I think this is in line with what you're proposing. It just means more work, because there are about another 10 standards that deal with events that need to be reviewed.

@jpmckinney jpmckinney mentioned this issue Mar 8, 2013
11 tasks
@evdb
Copy link
Author

evdb commented Mar 21, 2013

Best implemented with events #22. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants