Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should email be attached to a Person? #110

Open
LegoStormtroopr opened this issue Aug 26, 2015 · 4 comments
Open

Should email be attached to a Person? #110

LegoStormtroopr opened this issue Aug 26, 2015 · 4 comments
Labels

Comments

@LegoStormtroopr
Copy link

Lots of people that popolo could describe won't have emails, for example a record of historical parliamentarians won't have emails for anyone pre-2000.

Since there is a contact_details area, is it worth discussing if email be removed in favour of the contact_details and people can use the note field to indicate its preferredness?

@jpmckinney
Copy link
Member

There's no requirement to use the top-level email property for people who have none.

There had been earlier discussions of eliminating email since contact_details fulfills the same requirement (I think on a mailing list). email was added prior to contact_details, and was kept as it is a very common use case. Since there are many implementations of Popolo now, this would be a backwards-incompatible change.

@jpmckinney jpmckinney added the Bug label Dec 7, 2016
@jpmckinney
Copy link
Member

jpmckinney commented Dec 7, 2016

Will deprecate the top-level email and de-emphasize it in the docs. (ACTION)

@jpmckinney jpmckinney added Documentation ⬇️. Low priority ➡️. Can implement and removed Bug ⬇️. Low priority labels Dec 7, 2016
@tmtmtmtm
Copy link
Contributor

tmtmtmtm commented Dec 9, 2016

As a drive-by aside, I'm increasingly leaning towards migrating most email addresses in EveryPolitician to be on Memberships/Posts, rather than People, particularly when they're official parliamentary addresses. This would make it easier to clearly distinguish which email address you want to access, particularly in the case where someone holds multiple posts simultaneously (e.g. when they also have a ministerial address, or sit in both a regional and national legislature).

@jpmckinney
Copy link
Member

jpmckinney commented Dec 9, 2016

That's how it should be done :) and how OpenCivicData does it.

Will add that best practice to the docs. (ACTION)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants