Skip to content

Commit e3c0e0f

Browse files
author
Vesa Marttila
committed
Added unit tests and modified them to work in my project
1 parent 785e6f4 commit e3c0e0f

File tree

11 files changed

+351
-1
lines changed

11 files changed

+351
-1
lines changed

app/controllers/courses_controller.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
class CoursesController < ApplicationController
22
def index
3-
@courses = Course.find(:all)
3+
@courses = Course.all
44

55
respond_to do |format|
66
format.html # index.html.erb

app/models/course.rb

+4
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,8 @@ class Course < ActiveRecord::Base
33
validates_length_of :description, :in => 1..255 # TODO how much could this be?
44

55
has_many :course_instances, :dependent => :destroy
6+
7+
def self.all
8+
find(:all, :order => "created_at DESC")
9+
end
610
end

app/models/user.rb

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ class User < ActiveRecord::Base
1212
attr_accessor :password_confirmation
1313

1414
def before_save
15+
self.username.downcase!
16+
1517
if self.salt == nil
1618
self.salt = random_numbers(5)
1719
self.password = Digest::MD5.hexdigest(self.salt + self.password)

lib/tasks/rspec.rake

+144
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
1+
gem 'test-unit', '1.2.3' if RUBY_VERSION.to_f >= 1.9
2+
rspec_gem_dir = nil
3+
Dir["#{RAILS_ROOT}/vendor/gems/*"].each do |subdir|
4+
rspec_gem_dir = subdir if subdir.gsub("#{RAILS_ROOT}/vendor/gems/","") =~ /^(\w+-)?rspec-(\d+)/ && File.exist?("#{subdir}/lib/spec/rake/spectask.rb")
5+
end
6+
rspec_plugin_dir = File.expand_path(File.dirname(__FILE__) + '/../../vendor/plugins/rspec')
7+
8+
if rspec_gem_dir && (test ?d, rspec_plugin_dir)
9+
raise "\n#{'*'*50}\nYou have rspec installed in both vendor/gems and vendor/plugins\nPlease pick one and dispose of the other.\n#{'*'*50}\n\n"
10+
end
11+
12+
if rspec_gem_dir
13+
$LOAD_PATH.unshift("#{rspec_gem_dir}/lib")
14+
elsif File.exist?(rspec_plugin_dir)
15+
$LOAD_PATH.unshift("#{rspec_plugin_dir}/lib")
16+
end
17+
18+
# Don't load rspec if running "rake gems:*"
19+
unless ARGV.any? {|a| a =~ /^gems/}
20+
21+
begin
22+
require 'spec/rake/spectask'
23+
rescue MissingSourceFile
24+
module Spec
25+
module Rake
26+
class SpecTask
27+
def initialize(name)
28+
task name do
29+
# if rspec-rails is a configured gem, this will output helpful material and exit ...
30+
require File.expand_path(File.join(File.dirname(__FILE__),"..","..","config","environment"))
31+
32+
# ... otherwise, do this:
33+
raise <<-MSG
34+
35+
#{"*" * 80}
36+
* You are trying to run an rspec rake task defined in
37+
* #{__FILE__},
38+
* but rspec can not be found in vendor/gems, vendor/plugins or system gems.
39+
#{"*" * 80}
40+
MSG
41+
end
42+
end
43+
end
44+
end
45+
end
46+
end
47+
48+
Rake.application.instance_variable_get('@tasks').delete('default')
49+
50+
spec_prereq = File.exist?(File.join(RAILS_ROOT, 'config', 'database.yml')) ? "db:test:prepare" : :noop
51+
task :noop do
52+
end
53+
54+
task :default => :spec
55+
task :stats => "spec:statsetup"
56+
57+
desc "Run all specs in spec directory (excluding plugin specs)"
58+
Spec::Rake::SpecTask.new(:spec => spec_prereq) do |t|
59+
t.spec_opts = ['--options', "\"#{RAILS_ROOT}/spec/spec.opts\""]
60+
t.spec_files = FileList['spec/**/*_spec.rb']
61+
end
62+
63+
namespace :spec do
64+
desc "Run all specs in spec directory with RCov (excluding plugin specs)"
65+
Spec::Rake::SpecTask.new(:rcov) do |t|
66+
t.spec_opts = ['--options', "\"#{RAILS_ROOT}/spec/spec.opts\""]
67+
t.spec_files = FileList['spec/**/*_spec.rb']
68+
t.rcov = true
69+
t.rcov_opts = lambda do
70+
IO.readlines("#{RAILS_ROOT}/spec/rcov.opts").map {|l| l.chomp.split " "}.flatten
71+
end
72+
end
73+
74+
desc "Print Specdoc for all specs (excluding plugin specs)"
75+
Spec::Rake::SpecTask.new(:doc) do |t|
76+
t.spec_opts = ["--format", "specdoc", "--dry-run"]
77+
t.spec_files = FileList['spec/**/*_spec.rb']
78+
end
79+
80+
desc "Print Specdoc for all plugin examples"
81+
Spec::Rake::SpecTask.new(:plugin_doc) do |t|
82+
t.spec_opts = ["--format", "specdoc", "--dry-run"]
83+
t.spec_files = FileList['vendor/plugins/**/spec/**/*_spec.rb'].exclude('vendor/plugins/rspec/*')
84+
end
85+
86+
[:models, :controllers, :views, :helpers, :lib, :integration].each do |sub|
87+
desc "Run the code examples in spec/#{sub}"
88+
Spec::Rake::SpecTask.new(sub => spec_prereq) do |t|
89+
t.spec_opts = ['--options', "\"#{RAILS_ROOT}/spec/spec.opts\""]
90+
t.spec_files = FileList["spec/#{sub}/**/*_spec.rb"]
91+
end
92+
end
93+
94+
desc "Run the code examples in vendor/plugins (except RSpec's own)"
95+
Spec::Rake::SpecTask.new(:plugins => spec_prereq) do |t|
96+
t.spec_opts = ['--options', "\"#{RAILS_ROOT}/spec/spec.opts\""]
97+
t.spec_files = FileList['vendor/plugins/**/spec/**/*_spec.rb'].exclude('vendor/plugins/rspec/*').exclude("vendor/plugins/rspec-rails/*")
98+
end
99+
100+
namespace :plugins do
101+
desc "Runs the examples for rspec_on_rails"
102+
Spec::Rake::SpecTask.new(:rspec_on_rails) do |t|
103+
t.spec_opts = ['--options', "\"#{RAILS_ROOT}/spec/spec.opts\""]
104+
t.spec_files = FileList['vendor/plugins/rspec-rails/spec/**/*_spec.rb']
105+
end
106+
end
107+
108+
# Setup specs for stats
109+
task :statsetup do
110+
require 'code_statistics'
111+
::STATS_DIRECTORIES << %w(Model\ specs spec/models) if File.exist?('spec/models')
112+
::STATS_DIRECTORIES << %w(View\ specs spec/views) if File.exist?('spec/views')
113+
::STATS_DIRECTORIES << %w(Controller\ specs spec/controllers) if File.exist?('spec/controllers')
114+
::STATS_DIRECTORIES << %w(Helper\ specs spec/helpers) if File.exist?('spec/helpers')
115+
::STATS_DIRECTORIES << %w(Library\ specs spec/lib) if File.exist?('spec/lib')
116+
::STATS_DIRECTORIES << %w(Routing\ specs spec/routing) if File.exist?('spec/routing')
117+
::STATS_DIRECTORIES << %w(Integration\ specs spec/integration) if File.exist?('spec/integration')
118+
::CodeStatistics::TEST_TYPES << "Model specs" if File.exist?('spec/models')
119+
::CodeStatistics::TEST_TYPES << "View specs" if File.exist?('spec/views')
120+
::CodeStatistics::TEST_TYPES << "Controller specs" if File.exist?('spec/controllers')
121+
::CodeStatistics::TEST_TYPES << "Helper specs" if File.exist?('spec/helpers')
122+
::CodeStatistics::TEST_TYPES << "Library specs" if File.exist?('spec/lib')
123+
::CodeStatistics::TEST_TYPES << "Routing specs" if File.exist?('spec/routing')
124+
::CodeStatistics::TEST_TYPES << "Integration specs" if File.exist?('spec/integration')
125+
end
126+
127+
namespace :db do
128+
namespace :fixtures do
129+
desc "Load fixtures (from spec/fixtures) into the current environment's database. Load specific fixtures using FIXTURES=x,y. Load from subdirectory in test/fixtures using FIXTURES_DIR=z."
130+
task :load => :environment do
131+
ActiveRecord::Base.establish_connection(Rails.env)
132+
base_dir = File.join(Rails.root, 'spec', 'fixtures')
133+
fixtures_dir = ENV['FIXTURES_DIR'] ? File.join(base_dir, ENV['FIXTURES_DIR']) : base_dir
134+
135+
require 'active_record/fixtures'
136+
(ENV['FIXTURES'] ? ENV['FIXTURES'].split(/,/).map {|f| File.join(fixtures_dir, f) } : Dir.glob(File.join(fixtures_dir, '*.{yml,csv}'))).each do |fixture_file|
137+
Fixtures.create_fixtures(File.dirname(fixture_file), File.basename(fixture_file, '.*'))
138+
end
139+
end
140+
end
141+
end
142+
end
143+
144+
end

script/autospec

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
#!/usr/bin/env ruby
2+
gem 'test-unit', '1.2.3' if RUBY_VERSION.to_f >= 1.9
3+
ENV['RSPEC'] = 'true' # allows autotest to discover rspec
4+
ENV['AUTOTEST'] = 'true' # allows autotest to run w/ color on linux
5+
system((RUBY_PLATFORM =~ /mswin|mingw/ ? 'autotest.bat' : 'autotest'), *ARGV) ||
6+
$stderr.puts("Unable to find autotest. Please install ZenTest or fix your PATH")

script/spec

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
#!/usr/bin/env ruby
2+
if ARGV.any? {|arg| %w[--drb -X --generate-options -G --help -h --version -v].include?(arg)}
3+
require 'rubygems' unless ENV['NO_RUBYGEMS']
4+
else
5+
gem 'test-unit', '1.2.3' if RUBY_VERSION.to_f >= 1.9
6+
ENV["RAILS_ENV"] ||= 'test'
7+
require File.expand_path(File.dirname(__FILE__) + "/../config/environment") unless defined?(RAILS_ROOT)
8+
end
9+
require 'spec/autorun'
10+
exit ::Spec::Runner::CommandLine.run
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
require 'spec_helper'
2+
3+
describe CoursesController do
4+
5+
describe "routes" do
6+
it "should route the root to index" do
7+
params_from(:get, "/").should == {:controller => "courses", :action => "index"}
8+
end
9+
end
10+
11+
12+
before(:each) do
13+
@course_mock = mock_model(Course)
14+
end
15+
16+
describe "index" do
17+
# hitting database, this behaviour should be tested at unit tests
18+
# so we don't want to do this..
19+
it "should find all courses from db" do
20+
21+
# test-database is empty so we have to create something in it
22+
3.times {
23+
Course.create! :name => "Rails and rSpec", :description => "RRRRails"
24+
}
25+
26+
# courses cannot be listed unless authenticated, this should be
27+
# in a separate test but I am lazy
28+
session[:user_id] = 666
29+
30+
# make get request to application
31+
get :index
32+
33+
# should assign @courses with 3 objects from database
34+
assigns(:courses).should have(3).records
35+
end
36+
37+
# ..but instead use mocks
38+
it "should find all courses" do
39+
# we bypass hitting database and just check that method ".all" gets called
40+
# and returns mock object defined above
41+
42+
# courses cannot be listed unless authenticated, this should be
43+
# in a separate test but I am lazy
44+
session[:user_id] = 666
45+
46+
Course.should_receive(:all).and_return([@course_mock])
47+
48+
get :index
49+
50+
assigns(:courses).should == [@course_mock]
51+
end
52+
53+
end
54+
55+
56+
describe "show" do
57+
58+
it "should find correct course" do
59+
# our before filter works also in here!
60+
controller.should_receive(:authorize).and_return(true)
61+
62+
course_mock = mock_model(Course)
63+
Course.should_receive(:find).with("12").and_return(course_mock)
64+
65+
# Rails stack converts integer 12 to "12", as our assertion in above shows
66+
get :show, :id => 12
67+
68+
assigns(:course).should == course_mock
69+
end
70+
71+
end
72+
73+
end

spec/models/user_spec.rb

+51
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
require 'spec_helper'
2+
3+
describe User do
4+
before(:each) do
5+
@valid_attributes = {
6+
:username => "john",
7+
:password => "secretret"
8+
}
9+
10+
@valid_user = User.new(@valid_attributes)
11+
end
12+
13+
describe "creation" do
14+
it "should create a new instance given valid attributes" do
15+
User.create!(@valid_attributes)
16+
end
17+
18+
it "should lowercase username" do
19+
user = User.create!(@valid_attributes.merge({:username => "jOhN"}))
20+
user.username.should == "john"
21+
end
22+
end
23+
24+
describe "validation" do
25+
it "should require username to be between 3 and 15 characters" do
26+
user = User.new(@valid_attributes)
27+
user.should be_valid
28+
29+
user.username = "ab"
30+
user.should_not be_valid
31+
32+
user.username = "a"*16
33+
user.should_not be_valid
34+
end
35+
36+
it "should have a password" do
37+
@valid_user.password = ""
38+
@valid_user.should have(1).errors_on(:password)
39+
end
40+
41+
it "should require confirmation of password if confirmation is not nil" do
42+
user = User.new(@valid_attributes)
43+
user.should be_valid
44+
45+
user.password_confirmation = ""
46+
user.should_not be_valid
47+
end
48+
49+
end
50+
51+
end

spec/rcov.opts

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
--exclude "spec/*,gems/*"
2+
--rails

spec/spec.opts

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
--colour
2+
--format progress
3+
--loadby mtime
4+
--reverse

spec/spec_helper.rb

+54
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# This file is copied to ~/spec when you run 'ruby script/generate rspec'
2+
# from the project root directory.
3+
ENV["RAILS_ENV"] ||= 'test'
4+
require File.expand_path(File.join(File.dirname(__FILE__),'..','config','environment'))
5+
require 'spec/autorun'
6+
require 'spec/rails'
7+
8+
# Uncomment the next line to use webrat's matchers
9+
#require 'webrat/integrations/rspec-rails'
10+
11+
# Requires supporting files with custom matchers and macros, etc,
12+
# in ./support/ and its subdirectories.
13+
Dir[File.expand_path(File.join(File.dirname(__FILE__),'support','**','*.rb'))].each {|f| require f}
14+
15+
Spec::Runner.configure do |config|
16+
# If you're not using ActiveRecord you should remove these
17+
# lines, delete config/database.yml and disable :active_record
18+
# in your config/boot.rb
19+
config.use_transactional_fixtures = true
20+
config.use_instantiated_fixtures = false
21+
config.fixture_path = RAILS_ROOT + '/spec/fixtures/'
22+
23+
# == Fixtures
24+
#
25+
# You can declare fixtures for each example_group like this:
26+
# describe "...." do
27+
# fixtures :table_a, :table_b
28+
#
29+
# Alternatively, if you prefer to declare them only once, you can
30+
# do so right here. Just uncomment the next line and replace the fixture
31+
# names with your fixtures.
32+
#
33+
# config.global_fixtures = :table_a, :table_b
34+
#
35+
# If you declare global fixtures, be aware that they will be declared
36+
# for all of your examples, even those that don't use them.
37+
#
38+
# You can also declare which fixtures to use (for example fixtures for test/fixtures):
39+
#
40+
# config.fixture_path = RAILS_ROOT + '/spec/fixtures/'
41+
#
42+
# == Mock Framework
43+
#
44+
# RSpec uses it's own mocking framework by default. If you prefer to
45+
# use mocha, flexmock or RR, uncomment the appropriate line:
46+
#
47+
# config.mock_with :mocha
48+
# config.mock_with :flexmock
49+
# config.mock_with :rr
50+
#
51+
# == Notes
52+
#
53+
# For more information take a look at Spec::Runner::Configuration and Spec::Runner
54+
end

0 commit comments

Comments
 (0)