Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Test Connection' on Data Sources #450

Open
hennlo opened this issue Jun 7, 2023 · 3 comments · May be fixed by #470
Open

Add 'Test Connection' on Data Sources #450

hennlo opened this issue Jun 7, 2023 · 3 comments · May be fixed by #470
Assignees
Labels
A-db Area: DB A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-good-first-issue

Comments

@hennlo
Copy link
Member

hennlo commented Jun 7, 2023

Affected Areas

DB, UI

Feature Description

To verify that the connection with the specified credentials to the data source system works as intended a 'Test Connection' button for the UI or a internal call could be implemented.

Use Case(s)

When creating data source adapters but also for existing adapters.
This could also later on feed back some information and avoid accessing sources that might be currently offline or unreachable

Possible Solutions

Check when creating the connection Handler and do dummy executions on data source e.g. at PSQL SELECT 1

Possible Alternatives

No response

@hennlo hennlo added C-enhancement Category: An issue proposing an enhancement A-ui Area: UI A-db Area: DB E-good-first-issue labels Jun 7, 2023
@hrithik2200
Copy link

Hi, I am a newbie trying to get started with my journey of open source development. Can I get this issue assigned to me and some insight if possible on how to go about the issue?

@Ahmed-Elgamel
Copy link

I want to work ob this issue.So in order for every adapter to have test connection feature , we need to do 2 things.
First in the Polypheny-UI , add the necessary button in order to request the server to test the connection.And in Polypheny-DB we need to add in the DataSource abstract class an abstract method called testConnection().Then every class extending DataSource abstract class needs to provide its own implementation ex: csv data source and the other types of data sources available need to provide their own implementation

@hennlo hennlo assigned hennlo and Ahmed-Elgamel and unassigned hennlo Mar 4, 2024
@hennlo
Copy link
Member Author

hennlo commented Mar 4, 2024

Hi @Ahmed-Elgamel I've assigned the issue to you.

@Ahmed-Elgamel Ahmed-Elgamel linked a pull request Mar 13, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Area: DB A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-good-first-issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants