-
Notifications
You must be signed in to change notification settings - Fork 141
[AHM] fix scheduler and checking balance tests #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ggwpez
merged 11 commits into
oty-dev-asset-hub-migration-2506
from
muharem-ahm-scheduler-tests-fix
Sep 22, 2025
Merged
[AHM] fix scheduler and checking balance tests #911
ggwpez
merged 11 commits into
oty-dev-asset-hub-migration-2506
from
muharem-ahm-scheduler-tests-fix
Sep 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
approved these changes
Sep 17, 2025
acatangiu
approved these changes
Sep 17, 2025
x3c41a
reviewed
Sep 17, 2025
ggwpez
approved these changes
Sep 17, 2025
kianenigma
reviewed
Sep 18, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next failure after I run the test against this branch:
2025-09-18T01:01:36.801638Z INFO runtime::frame-support: 🩺 Running "RcMigrator" try-state checks
2025-09-18T01:01:37.763118Z ERROR runtime::defensive: a defensive failure has been triggered; please report the block number at https://github.com/paritytech/polkadot-sdk/issues: "ah_checking_balance_before ==\npallet_balances::Pallet::<AhRuntime>::minimum_balance()"
thread 'tests::post_migration_checks_only' panicked at /Users/kianenigma/Desktop/Parity/ahm-dryrun/runtimes/pallets/ah-migrator/src/society.rs:217:4:
NextIntakeAt should be empty on the relay chain after migration
Makes sense, probably the on-init of pallet-society is still running post migration and populating this?
Contributor
|
@muharem pushed a few of the tests that still fail ahead of you. Afterwards, I still get: |
ggwpez
approved these changes
Sep 19, 2025
…-ahm-scheduler-tests-fix
…' into muharem-ahm-scheduler-tests-fix
1 task
4111ecf
into
oty-dev-asset-hub-migration-2506
51 of 63 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix scheduler and checking balance tests failures reported from dry runs
fixes https://github.com/paritytech/ahm-dryrun/actions/runs/17782824014/job/50544999858#step:25:1153