[AHM] Pallet multisig tests #666

re-gius · 2025-04-08T10:33:00Z

Removing migrated multisigs from the relay chain
Add pre and post migration tests.
Check that you can re-create a Relay Chain multisig on Asset Hub and the ID stays the same

Notice that multisigs storage items are not actually migrated to Asset Hub, but only the multisig accounts (with non-zero balance) are, so that they can be re-created on asset hub by users if they want to. Thus, we only need to check that multisig storage items are deleted from the relay chain and relevant multisig accounts are migrated to asset hub.

Finally, a separate test creates a new multisig on the relay chain with non-zero balance and checks that the same multisig can be re-created on asset hub while preserving its balance

ggwpez · 2025-04-08T11:54:53Z

pallets/ah-migrator/src/multisig.rs

 }
+
+#[cfg(feature = "std")]
+impl<T: Config, W> crate::types::AhMigrationCheck for MultisigMigrator<T, W> {


I think the weight is not needed?
You can also define a new struct, like MultisigMigrationCheck or something to not having to carry the weight around.

Changed in 089a098

ggwpez · 2025-04-08T11:57:06Z

pallets/rc-migrator/src/multisig.rs

+			.filter(|multisig_id| {
+				let multisig_balance =
+					<<T as pallet_multisig::Config>::Currency as frame_support::traits::Currency<
+						<T as frame_system::Config>::AccountId,


I let it slit the last time but now please no deeply nested code anymore.
Just a clean let mut multisig_ids = vec... and then a for loop to populate it please.

Reading these nested closures it a bit hard otherwise.

Ok, changed in 089a098

ggwpez · 2025-04-08T11:58:32Z

pallets/ah-migrator/src/multisig.rs

+			"Number of multisigs on Asset Hub should be the same before and after migration"
+		);
+		for account_id in rc_pre_payload {
+			assert!(


Suggested change

assert!(

// Assert storage 'Multisig::Multisigs::ah_post::consistent'

assert!(

Fixed in 089a098

re-gius · 2025-04-08T14:04:24Z

Don't merge

I'm currently working on adding a couple extra tests

re-gius · 2025-04-10T16:50:05Z

Ready for review

Please @ggwpez check the tests I added in 0ceea22 (with a small fix in 8a3ab4e)

ggwpez

Looks pretty good

integration-tests/ahm/src/multisig_test.rs

github-actions · 2025-04-11T10:45:35Z

Review required! Latest push from author must always be reviewed

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez · 2025-04-16T10:55:17Z

Somehow the test does not work on Westend, can you debug it please?
I took a quick look but did not find the issue. Account 5FVptfYHxEXpGG8y3VYWVA6sTv2VA4HmZkDALm787p7Ysjiv is somehow migrated out from the relay but does not arrive at AH...

re-gius · 2025-04-18T15:45:44Z

Currently testing only Polkadot

@ggwpez Tests fail on Westend because some accounts balances are not correctly migrated to Asset Hub

muharem

I think for multisigs we should test that deposits are unreserved on AH

muharem · 2025-04-22T18:43:38Z

integration-tests/ahm/src/multisig_test.rs

+#[cfg(feature = "ahm-polkadot")]
+type RelayRuntime = polkadot_runtime::Runtime;
+#[cfg(feature = "ahm-polkadot")]
+type AssetHubRuntime = asset_hub_polkadot_runtime::Runtime;
+#[cfg(feature = "ahm-polkadot")]
+type RelayRuntimeOrigin = polkadot_runtime::RuntimeOrigin;
+#[cfg(feature = "ahm-polkadot")]
+type AssetHubRuntimeOrigin = asset_hub_polkadot_runtime::RuntimeOrigin;
+#[cfg(feature = "ahm-polkadot")]
+type RelayRuntimeCall = polkadot_runtime::RuntimeCall;
+#[cfg(feature = "ahm-polkadot")]
+type AssetHubRuntimeCall = asset_hub_polkadot_runtime::RuntimeCall;


might be useful under porting_prelude, we also have some aliases there already. this is just suggestion.

Thanks, moved to porting_prelude in d8c8002

muharem · 2025-04-22T18:52:40Z

pallets/rc-migrator/src/multisig.rs

-			// TODO delete old
+			// Remove the last key from storage if it exists
+			if let Some((id, call_hash)) = last_key {
+				aliases::Multisigs::<T>::remove(id, call_hash);


it would be nicer if we remove in one place, Ok(ms) arm where we push into the batch might work for it

Changed in d8c8002

muharem · 2025-04-22T18:54:25Z

pallets/rc-migrator/src/accounts.rs

+			account_info,
 		);

+		let _ = pallet_balances::Pallet::<T>::ensure_upgraded(&who);


it would be nice if you leave a comment here why we want this

It came from another PR, thanks for noticing. Removed in 3f1c2bf

muharem · 2025-04-22T18:55:11Z

pallets/ah-migrator/src/multisig.rs


 use crate::*;
 use hex_literal::hex;
+use pallet_rc_migrator::types::AccountIdOf;


probably causing the unused import warning

There's no unused import warning from this file right now

even if you compile Polkadot AH runtime without std?

Changed in b1fdcc8

muharem · 2025-04-24T13:38:21Z

pallets/rc-migrator/src/multisig.rs

 			let Some((k1, k2, multisig)) = kv else {
+				// Remove the last key from storage if it exists
+				if let Some((id, call_hash)) = last_key {
+					aliases::Multisigs::<T>::remove(id, call_hash);


still need this?

Thanks for noticing, removed in b1fdcc8

muharem · 2025-04-24T13:40:32Z

I think for multisigs we should test that deposits are unreserved on AH

@re-gius what you think about this?

re-gius · 2025-04-24T14:47:07Z

I think for multisigs we should test that deposits are unreserved on AH

@re-gius what you think about this?

Okay, currently working on this

re-gius · 2025-04-28T15:25:04Z

I think for multisigs we should test that deposits are unreserved on AH

@re-gius what you think about this?

@muharem this would require either storing events for many blocks (to check for Unreserved events) or do complex checks that interact with unreserve operations from other pallets. I would skip it for now

re-gius · 2025-05-19T15:44:16Z

@ggwpez @muharem this should be ready to be merged

A high-level look of the migration is this: <img width="1204" height="745" alt="Screenshot 2025-09-17 at 18 23 57" src="https://github.com/user-attachments/assets/1fb39ef8-5efa-4db2-81db-6dd775af3a39" /> You can see the main components being the `pallet_rc_migrator` and `pallet_ah_migrator`. The RC migrator pallet takes data out of the RC storage and enqueues it for AH through XCM::Transact calls to the AH migrator pallet. Each pallet on the RC side has a migrator module that handles the removal of the old data and creation of the messages for AH. AH then processes these messages through the MQ pallet and acknowledges back to RC that they were processed (not shown in the graphic). There is rate-limiting code in place to prevent it from overloading the DMP queue or Asset Hub. ## For Reviewers The review comments are being addressed in #915. We need eyes on the Core part that is described below. ## Core STM The main stage transitions look like this. The only manual part is the scheduling call by the fellowship that kicks off the procedure: * `Pending` wait for Fellowship to call `schedule_migration(when)` -> Scheduled * `Scheduled` waiting for scheduled block -> `WaitingForAH` * `WaitingForAH` AH replies that it is ready -> `WarmUp` * `WarmUp` waiting for warm-up end -> `Starting` * `Starting` doing some startup initialization -> `DataMigration` * `DataMigration` MAIN PART **all pallet migrations finish** -> `CoolOff` * `CoolOff` waiting for cool-off to end -> `SignalMigrationFinish` * `SignalMigrationFinish` send signal to AH that we are done -> `MigrationDone` * `MigrationDone` finished, unlock all Pallets. ### State Machine The core State Machine lives in the `RcMigrator` pallet in its `on_initialize`: https://github.com/polkadot-fellows/runtimes/blob/8ef1cc739d756b109dc93eaf3b9da00e3dcf1383/pallets/rc-migrator/src/lib.rs#L1338-L1342 On each block the Rc Migrator checks the current state and possibly progresses to the next one. It will only do a single state transition per block to reduce complexity of the code. Generally, there are three states per pallet (called [*stages*](https://github.com/polkadot-fellows/runtimes/blob/8ef1cc739d756b109dc93eaf3b9da00e3dcf1383/pallets/rc-migrator/src/lib.rs#L190-L389) in the code). Some pallets have more then three, but it is generally still a multiple of three and always follows the pattern of `PalletInit`, `PalletOngoing { cursor }`, `PalletDone`: https://github.com/polkadot-fellows/runtimes/blob/8ef1cc739d756b109dc93eaf3b9da00e3dcf1383/pallets/rc-migrator/src/lib.rs#L239-L244 Each pallet then has one migrator struct (eg. `MultisigMigrator<T>`) that migrates the storage items from the Relay side. It lives in the module of its name `rc-migrator/src/multisig.rs` respectively. Taking Multisigs as an example; you can find two functions in the migrator struct: `migrate_many` and `migrate_single`. The former one is from the [`PalletMigration` trait](https://github.com/polkadot-fellows/runtimes/blob/715dbb4455a127066d0118ce7a096c72200e1126/pallets/rc-migrator/src/types.rs#L209-L221). The `migrate_single` function is done by convention to keep the code readable. The `migrate_many` does the following: - Weight accounting for the RC side: Normal weight tracking to not have overtime RC blocks - Weight accounting for the AH side: Ensuring to not send messages that would take up too much weight on AH processing - Ensure that DMP messages are sensibly sized by using the `XcmBatchAndMeter` - Taking the data out from the Relay chain (deleting it) - Including the data into a DMP message and sending it towards AH ### AH Side The main logic on Asset Hub lives in the `AhMigrator` pallet. It contains at least one extrinsic per pallet to receive the incoming data from the RC. We are using extrinsics since RC is wrapping the data into XCM::Transacts: https://github.com/polkadot-fellows/runtimes/blob/9a20b12e22b019c1c0b15b9af897567a559e424c/pallets/ah-migrator/src/lib.rs#L650-L653 This calls into the [`multisig` module](https://github.com/polkadot-fellows/runtimes/blob/6b603ca47e5c49b3a898be3f8f6b078c424f42a0/pallets/ah-migrator/src/multisig.rs#L37) to integrate the data into the storage. Per convention we are emitting events for each item and the whole batch. The main task of the AH side is to integrate the data. In the example of the multisig it is special since we do not migrate the multisig, but only the reserved account which will be unreserved on AH. ## Messaging Logic The messaging is ACK based. The Relay sends message to Asset Hub up to a specified limit (50). The limit can be adjusted on the fly through a dedicated dispatchable call, restricted to Admin and Manager roles. The limit may be overstepped by the configured batch-size (10), so in total there should never be more than 60 DMPs queued. Each DMP is set to at most [50KB](https://github.com/polkadot-fellows/runtimes/blob/8ef1cc739d756b109dc93eaf3b9da00e3dcf1383/pallets/rc-migrator/src/lib.rs#L131). The Relay Chain migrator creates a query for each XCM data message using the XCM query–response primitives and attaches a response status request from Asset Hub to the message. The XCM executor on Asset Hub then sends back the response status for every message with such a request. The Relay migrator stores each data message sent to Asset Hub until it receives confirmation of successful processing. It also provides a dispatchable call, available only to Admin and Manager roles, to resend any unconfirmed messages. A bug that prevented certain messages from being accounted for during a particulat pallet migration caused the Westend AHM stall. The system was queuing too many DMPs, which forced WAH to author an overweight block while attempting to process them all at once. ## Call Filtering Pallet calls are filtered during the migration for three reasons: - prevent malicious users from spamming the chain with cheap TX and slowing down the migration - prevent users from sending many UMPs out of AH to clog up the UMP queue - prevent interference with pallets that are being migrated to avoid messing up their storage invariants Both RC and AH provide call filters for `Before`, `During` and `After` the migration. As you can see, most things are disabled during the migration on both chains. After the migration, Relay chain keeps pretty much everything disabled since it was now enabled on AH: - Before: RC everything enabled, AH all new pallets disabled (staking, gov etc) - During: RC mostly everything disabled, AH mostly everything disabled - After: RC mostly everything disabled (staking, gov etc), AH everything enabled (staking, gov etc) This is implemented by returning three bools, one for each phase: https://github.com/polkadot-fellows/runtimes/blob/88f4aaf62236fbee9cfb9183e44333bac45b1371/system-parachains/asset-hubs/asset-hub-polkadot/src/ah_migration/call_filter.rs#L81-L83 ## Testing and Dry-Runs https://github.com/paritytech/ahm-dryrun is the repository for testing infrastructure for AHM. As of now, the following is being tested there (as a part of "[AHM Flow (all steps)](https://github.com/paritytech/ahm-dryrun/actions/workflows/zombie-bite.yml)" nightly action): * Dry-running a migration on a fork of Kusama * Re-running the rust unit tests introduced in this branch * Re-running a subset of the same tests, re-written in TS * Re-running PET tests. Each action produces a table with the summary of the test results: <img width="682" height="357" alt="Screenshot 2025-09-19 at 09 03 20" src="https://github.com/user-attachments/assets/69c1e37d-6f8f-4b57-b97f-75781a1e1a3a" /> And 4 snapshot files (2 real databases, 2 try-runtime snapshots) which can be used to re-run any of the tests, or run the pre/post migration chain, locally. <img width="1347" height="476" alt="Screenshot 2025-09-19 at 09 03 40" src="https://github.com/user-attachments/assets/127cbf76-b2fb-467f-8fef-3e93a9a709f6" /> <details><summary>Full Changelog</summary> <p> - **[AHM] OpenGov for Kusama AH (#877)** - **Relay Chain Accounts to Asset Hub Migration (#515)** - **Test Relay<->AH migration through DMP messages (#528)** - **[AHM] Improve account migration (#532)** - **[AHM] Add multisig migration (#534)** - **[AHM] Proxy migration (#542)** - **[AHM] Cleanup and add Preimage doc (#543)** - **[AHM] Improve accounts migration (#550)** - **[AHM] Preimage migration (#545)** - **[AHM] Add Polkadot call filtering (#559)** - **[AHM] Nomination pools (#562)** - **[AHM] referenda pallet (#558)** - **[AHM] Cleanup (#565)** - **[AHM] Scheduler Pallet (#569)** - **[AHM] Fast unstake and Bags list (#563)** - **[AHM] Pallet claims (#570)** - **[AHM] Conviction Voting Pallet (#578)** - **[AHM] Pallet Indices (#577)** - **[AHM] pause scheduler during migration (#580)** - **[AHM] Asset rate pallet migration (#581)** - **[AHM] Bounties data migration (#585)** - **[AHM] Vesting (#575)** - **[AHM] fix the rc-migrator call filter (#598)** - **[AHM] Sovereign Account Translation (#594)** - **[AHM] Crowdloans (#592)** - **[AHM] Set up AH migration testing framework for single pallets (#597)** - **[AHM] Stage management (#584)** - **[AHM] Do not pause inherents 🙈 (#609)** - **[AHM] Relay Chain accounts' reserves (#602)** - **[AHM] Benchmarks (#589)** - **[AHM] Pallet testing framework (#612)** - **[AHM] fix xcm weight at most (#617)** - **[AHM] Improve weight accounting for accounts migration (#618)** - **[AHM] AH acks messages from RC (#620)** - **[AHM] Pure Proxy Investigation (#621)** - **[AHM] Remove migrated items for pallet preimage and improve testing (#619)** - **[AHM] Referenda metadata (#633)** - **[AHM] Fix accounts migration failures (#628)** - **[AHM] refactor events and enable scheduled migration start (#634)** - **[AHM] Migrating DOT total issuance tracking from RC to AH (#607)** - **[AHM] Comment faulty checks out (#640)** - **Account migrator refactor (#639)** - **[AHM] Rebase (#641)** - **[AHM] Run AHM test in CI (#642)** - **[AHM] Vesting test (#615)** - **[AHM] bags_list and conviction_voting tests (#632)** - **[AHM] Treasury pallet migration (#624)** - **[AHM] Fix tests for pallet preimage (#643)** - **[AHM] Test Coverage Report (#650)** - **[AHM] deactivate/reactivate total issuance & weights (#648)** - **[AHM] add sudo behind feature flag (#657)** - **[AHM] fast_unstake tests (#658)** - **[AHM] asset_rate test (#660)** - **[AHM] Pallet treasury tests (#664)** - **[AHM] Improve account balances integration tests (#655)** - **[AHM] Integrate AH migrator weights to RC (#665)** - **Testing for bounties migration (#669)** - **[AHM] Westend port adapters (#652)** - **[AHM] fix checking account and total issuance migration (#636)** - **[AHM] Bump polkadot relay and AH versions (#667)** - **[AHM] Fix tests for pallet treasury (#671)** - **[AHM] Claims and Crowdloan tests (#622)** - **[AHM] Benchmarks (#663)** - **[AHM] Add Asset Hub CallFilter (#670)** - **[AHM] Westend staking migration (#689)** - **[AHM] Referenda migration storage checks (#672)** - **[AHM] AH benchmarks cleanup (#690)** - **[AHM] Westend Async Staking Migration (#691)** - **[AHM] Relay Chain migrator benchmarks (#692)** - **[AHM] Asset Hub ops pallet benchmarks (#693)** - **[AHM] Xcm send weights and Batch helper types (#694)** - **Finish staking Westend (#695)** - **[AHM] Account provider/consumer references (#702)** - **[AHM] Fix westend builds (#704)** - **[AHM] Generate weights (#706)** - **[AHM] Proxy fixes and more tests (#707)** - **[AHM] Docs and simpler events (#699)** - **[AHM] Test call decoding (#710)** - **[AHM] Emulated test for migration with async backing (#717)** - **[AHM] Increase test coverage (#720)** - **[AHM] Add referenda checks to Westend migration (#713)** - **[AHM] Nom_pools test (#677)** - **[AHM] Scheduler storage item checks (#680)** - **[AHM] Update Polkadot Snapshot (#725)** - **[AHM] Pallet multisig tests (#666)** - **[AHM] Adapt XCM configuration to account for changes before and after migration (#722)** - **[AHM] document checking account migration (#716)** - **[AHM] Dependency fixes for integration tests and the Polkadot runtime (#751)** - **[AHM] Remove empty conviction voting filter (#750)** - **[AHM] Missing TODOs and `AccountState` type update (#742)** - **[AHM] DMP prioritization on AH (#772)** - **[AHM] Disable #[pallet::hooks] for migrating pallets during migration (#784)** - **[AHM] AH messages prioritization on RC (#787)** - **[AHM] Cache test snapshots and include more tests into CI job (#788)** - **[AHM] Cleanup Westend feature (#789)** - **[AHM] Introducing the Cool-Off stage (#786)** - **[AHM] Flow Control System (#780)** - **[AHM] Migrate pallet delegated-staking to AH (#791)** - **[AHM] Merge master into dev branch (#793)** - **[AHM] Disable indirect XCMs from RC to AH and vice versa during migration (#774)** - **Rebase** - **bring back RelayTreasuryLocation to make old tests compiole** - **[AHM] Missing `RootLocation` for WaivedLocation for AHP (#798)** - **[AHM] Missing `SecretaryEntities` for AHP (#797)** - **[AHM] Migration idempotency (#808)** - **[AHM] Block number providers for migrating pallets (#809)** - **[AHM] Copy latest ah-ops pallet from the SDK (#810)** - **[AHM / ah-migrator]: Implement RC->AH account translation `mocked` migration across all involved pallets (#807)** - **[AHM] Complete account balances tests (#674)** - **[AHM] Address TODOs (#815)** - **[AHM] Async staking config (#812)** - **[AHM] Optional migration manager account id (#818)** - **[AHM] Type safe Hold and Freeze-Reason translation (#819)** - **[AHM] Create new response query on resend and tests (#816)** - **PolkadotAssetHub: Enable Async Backing (#763)** - **Ensure no era planned when migration starts (#728)** - **[AHM] with async backing (#822)** - **[AHM] Staking migration (#821)** - **identify with only validator account** - **[AHM] Tests work for Paseo (#827)** - **[AHM] Child bounties (#613)** - **[AHM] Cleanup and linter fixes (#828)** - **[AHM] Fix snowbridge test - wrong import of `RelayTreasuryPalletAccount` (instead of AH, it should be BH) (#831)** - **[AHM] Account Translation mapping (#829)** - **Fast unstake: remove alias** - **fmt** - **[AHM] Max migrated items per block (#834)** - **[AHM] Record migration timings (#835)** - **[AHM] Remove storage aliases and cleanup (#832)** - **[AHM] fix Kusama bags list pallet benchmarks (#836)** - **[AHM] Unprocessed msg buffer size 50 (#839)** - **[AHM] Post migration cool off stage (#841)** - **[AHM] Multisig test and storage_alias cleanup (#842)** - **[AHM] Remove fast-unstake and test fixes (#846)** - **Run try-state check for all pallets post AHM rust tests (#833)** - **[AHM] Preserve on RC manager' account (#843)** - **[AHM] Filter staking calls before migration starts (#847)** - **[AHM] State Decode Tests (#848)** - **[AHM] Send xcm extrinsic within migrator pallets (#851)** - **Merge and cleanup merge commit** - #845 - #852 - #862 - #875 - #872 - #877 - #626 - #879 - #885 - #886 - #882 - #883 - #854 - #888 - #895 - #892 - #896 - #889 </p> </details> // only to let all CIs to execute for now - [ ] Does not require a CHANGELOG entry --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Signed-off-by: Adrian Catangiu <[email protected]> Signed-off-by: Andrei Sandu <[email protected]> Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Muharem <[email protected]> Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: Andrii <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Yuri Volkov <[email protected]> Co-authored-by: s0me0ne-unkn0wn <[email protected]> Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: Branislav Kontur <[email protected]> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com> Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> Co-authored-by: ordian <[email protected]> Co-authored-by: Alistair Singh <[email protected]> Co-authored-by: Sergej Sakac <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Serban Iorga <[email protected]> Co-authored-by: Xiliang Chen <[email protected]> Co-authored-by: Nikolai Kozlov <[email protected]> Co-authored-by: nkprt <[email protected]> Co-authored-by: Eugenio Paluello <[email protected]> Co-authored-by: Javier Viola <[email protected]> Co-authored-by: polka.dom <[email protected]> Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Karol Kokoszka <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Clara van Staden <[email protected]> Co-authored-by: Ankan <[email protected]> Co-authored-by: clangenb <[email protected]> Co-authored-by: Andrei Sandu <[email protected]> Co-authored-by: Andrei Sandu <[email protected]> Co-authored-by: Alexandre Baldé <[email protected]> Co-authored-by: Maksym H <[email protected]> Co-authored-by: Alin Dima <[email protected]> Co-authored-by: Alexander Theißen <[email protected]> Co-authored-by: Christian Langenbacher <[email protected]> Co-authored-by: Ankan <[email protected]> Co-authored-by: Karol Kokoszka <[email protected]> Co-authored-by: brenzi <[email protected]> Co-authored-by: Doordashcon <[email protected]> Co-authored-by: eskimor <[email protected]> Co-authored-by: Robert <[email protected]> Co-authored-by: Raymond Cheung <[email protected]> Co-authored-by: Maciej <[email protected]> Co-authored-by: Paolo La Camera <[email protected]> Co-authored-by: kianenigma <[email protected]> Co-authored-by: Alexandru Vasile <[email protected]> Co-authored-by: Alexander Cyon <[email protected]>

remove multisigs from RC + add tests

b7fa241

re-gius mentioned this pull request Apr 8, 2025

[AHM] [tracking] Integration testing for pallet migration #644

Closed

18 tasks

ggwpez reviewed Apr 8, 2025

View reviewed changes

move tests to a separate struct

089a098

re-gius added 2 commits April 10, 2025 16:29

adding tests for re-creating a relay chain multisig on asset hub

0ceea22

Merge branch 'dev-asset-hub-migration' into re-gius/ahm-multisig-tests

918665e

re-gius added 2 commits April 10, 2025 19:01

small fix to tests

8a3ab4e

fix comments

f886d12

ggwpez approved these changes Apr 10, 2025

View reviewed changes

change struct name

101374e

github-actions bot requested a review from ggwpez April 11, 2025 10:45

re-gius and others added 4 commits April 14, 2025 08:56

allow for westend multisig testing

d3a67bf

remove multisig tests for westend

ea0a3ce

fix

3a70b89

Upgrade accounts to V2

d0d7048

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

re-gius added 8 commits April 17, 2025 17:20

Merge branch 'dev-asset-hub-migration' into re-gius/ahm-multisig-tests

9729c2b

debug

3c15ad0

debug

ae2eff8

put back new multisigs tests

1e71ccd

debug

55103b1

undo debug

82d4dbe

debug

3175764

fix

4c89f69

muharem reviewed Apr 22, 2025

View reviewed changes

re-gius added 6 commits April 23, 2025 15:21

Remove mixup from other PR

3f1c2bf

Small fix + move aliases to porting prelude

d8c8002

Merge branch 'dev-asset-hub-migration' into re-gius/ahm-multisig-tests

447a389

fix

645c30d

fix porting prelude

386b135

Merge branch 'dev-asset-hub-migration' into re-gius/ahm-multisig-tests

b6d6cc9

muharem reviewed Apr 24, 2025

View reviewed changes

small fixes

b1fdcc8

re-gius added 2 commits April 24, 2025 17:03

fmt

5518a32

Merge branch 'dev-asset-hub-migration' into re-gius/ahm-multisig-tests

127576f

re-gius added 11 commits April 28, 2025 17:37

Merge branch 'dev-asset-hub-migration' into re-gius/ahm-multisig-tests

6cc35b1

remove multisigs from rc

b58c9bc

Merge branch 'dev-asset-hub-migration' into re-gius/ahm-multisig-tests

46c6815

Merge branch 'dev-asset-hub-migration' into re-gius/ahm-multisig-tests

27b66f1

merge fix

726311e

merge fix

bd27c48

nit

2e267ea

Log fixes

1579e40

log fixes

43a3359

Remove balance checks from sample multisig

c335ce4

test is only on polkadot

febc316

ggwpez merged commit 243bdd2 into polkadot-fellows:dev-asset-hub-migration Jun 6, 2025
38 of 47 checks passed

re-gius deleted the re-gius/ahm-multisig-tests branch July 22, 2025 15:32

ggwpez mentioned this pull request Aug 18, 2025

THE ASSET HUB MIGRATION (Please Review) #856

Merged

1 task

	assert!(
	// Assert storage 'Multisig::Multisigs::ah_post::consistent'
	assert!(

[AHM] Pallet multisig tests #666

[AHM] Pallet multisig tests #666

Uh oh!

Conversation

re-gius commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

re-gius commented Apr 8, 2025

Uh oh!

re-gius commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ggwpez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

ggwpez commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

re-gius commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

muharem left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muharem commented Apr 24, 2025

Uh oh!

re-gius commented Apr 24, 2025

Uh oh!

re-gius commented Apr 28, 2025

Uh oh!

re-gius commented May 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

re-gius commented Apr 8, 2025 •

edited

Loading

re-gius commented Apr 10, 2025 •

edited

Loading

ggwpez commented Apr 16, 2025 •

edited

Loading

re-gius commented Apr 18, 2025 •

edited

Loading