State trie migrations ah #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nkpar
commented
Feb 25, 2025
nkpar
commented
- Does not require a CHANGELOG entry
Eliminated the conditional `state-trie-version-1` feature and all associated code, including configurations, parameterization, and tests. The `state-trie-migration` pallet is now always included without feature gating.
Reorganized and reordered runtime configuration types to enhance readability and consistency. Adjusted type alias placements, added missing types, and restructured constants for better maintainability and alignment across pallets.
This reverts commit cb23f58.
Replaces `EnsureSignedBy<RootMigController, AccountId>` with `EnsureRoot<AccountId>` for `ControlOrigin`. This simplifies migration control logic by ensuring only the root origin has full authority over the pallet.
Updated `ControlOrigin` to support either Root or Fellowship origins. Modified `SignedFilter` to use `EnsureSigned`.
cargo fmt
Bump spec_version for AH Kusama
ggwpez
reviewed
Feb 25, 2025
Member
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
I think we need clarity on the bot accounts to use for the migration; otherwise looks good
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
…hub-polkadot in migration workflow
Contributor
Author
|
The migration bot code is in paritytech/polkadot-scripts/blob/master/src/services/state_trie_migration.ts |
ggwpez
reviewed
Feb 26, 2025
64 tasks
kianenigma
reviewed
Feb 26, 2025
kianenigma
reviewed
Feb 26, 2025
Merged
ggwpez
approved these changes
Mar 5, 2025
bkchr
reviewed
Mar 6, 2025
Contributor
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
One question regarding the changes in the CI code, otherwise looks good.
| "is_relay": false, | ||
| "blocktime": 12000 | ||
| "blocktime": 12000, | ||
| "runtime_args": "--overwrite-state-version 1" |
Contributor
There was a problem hiding this comment.
Why do we need this? The on chain version is still 0?
Contributor
Author
There was a problem hiding this comment.
@bkchr As I updated state version in this PR - otherwise check will fail
Member
There was a problem hiding this comment.
The externalities initialize with the state version of the snapshot (0) and then at the end of the block it is 1 and fails to match the state root. Now instead we initialise with 1.
Contributor
There was a problem hiding this comment.
Are we building a block because of the possible multi block migrations?
kianenigma
reviewed
Mar 6, 2025
Co-authored-by: Kian Paimani <[email protected]>
kianenigma
reviewed
Mar 6, 2025
kianenigma
reviewed
Mar 6, 2025
kianenigma
reviewed
Mar 6, 2025
Co-authored-by: Kian Paimani <[email protected]>
kianenigma
reviewed
Mar 6, 2025
Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
bkchr
reviewed
Mar 6, 2025
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
bkchr
reviewed
Mar 6, 2025
bkchr
approved these changes
Mar 6, 2025
ggwpez
approved these changes
Mar 7, 2025
Member
|
/merge |
fellowship-merge-bot
bot
merged commit 22d1ab8
into
polkadot-fellows:main
64 checks passed
Contributor
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
Release 1.4.2 for: - #535 (PAH and KAH) - #614 (P Collectives) - #604 (PAH and KAH) --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.