Skip to content

Conversation

@bkontur
Copy link
Contributor

@bkontur bkontur commented Feb 12, 2025

This PR:

  • Removes previously executed migrations based on the v1.4.2 (and older) tag – remove-migrations.patch.txt.
  • Disables MBM migrations for all runtimes in the check-migrations CI.

@bkontur
Copy link
Contributor Author

bkontur commented Feb 13, 2025

@ggwpez what do you suggest here? Wait for fix paritytech/try-runtime-cli#109 or merge this PR?

@bkchr
Copy link
Contributor

bkchr commented Feb 13, 2025

Why? Did we had any failing tests because of this?

@ggwpez
Copy link
Member

ggwpez commented Feb 13, 2025

@ggwpez what do you suggest here? Wait for fix paritytech/try-runtime-cli#109 or merge this PR?

I guess we have to merge this so that the tests run again properly. There is still no real maintainer of the try-runtime-cli, only a part-time one that has no availability until EOM.

@bkchr
Copy link
Contributor

bkchr commented Feb 14, 2025

/cmd bench --runtime coretime-kusama --pallet pallet_xcm

@bkchr
Copy link
Contributor

bkchr commented Feb 14, 2025

@bkontur just abusing your pr a little bit :P

@github-actions
Copy link

Command "bench --runtime coretime-kusama --pallet pallet_xcm" has started 🚀 See logs here

@github-actions
Copy link

Command "bench --runtime coretime-kusama --pallet pallet_xcm" has failed ❌! See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Feb 14, 2025

Command "bench --runtime coretime-kusama --pallet pallet_xcm" has failed ❌! See logs here

@mordamax I think this subweight comparision should compare PR's branch against the PR's target/base branch here: https://github.com/polkadot-fellows/runtimes/blob/main/.github/workflows/cmd.yml#L351

because now it compares to the origin/main, which is in my fork, but it is not up-to-date - so tthat is why there is so big output for every pallet/runtime
https://github.com/polkadot-fellows/runtimes/actions/runs/13330241520/job/37234272415#step:15:10


So here: https://github.com/polkadot-fellows/runtimes/blob/main/.github/workflows/cmd.yml#L351 we should change refs/remotes/origin/main for something which points to the actual PR's target branch

@bkontur
Copy link
Contributor Author

bkontur commented Feb 14, 2025

/cmd bench --runtime coretime-kusama --pallet pallet_xcm

@github-actions
Copy link

Command "bench --runtime coretime-kusama --pallet pallet_xcm" has started 🚀 See logs here

@github-actions
Copy link

Command "bench --runtime coretime-kusama --pallet pallet_xcm" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
system-parachains/coretime/coretime-kusama/src/weights/pallet_xcm.rs force_xcm_version 109.49us 116.36us +6.28
system-parachains/coretime/coretime-kusama/src/weights/pallet_xcm.rs take_response 163.85us 173.93us +6.15

@bkontur
Copy link
Contributor Author

bkontur commented Feb 14, 2025

@mordamax @bkchr very nice, looks like the bot finally passed :), but we need to fix this: #590 (comment)

@mordamax
Copy link
Contributor

@bkontur it definitely needs improvements, as it was first attempt here, and never worked to test&iterate. Feel free to change it :)

the polkadot-sdk one is a bit more advanced and stable

@bkontur
Copy link
Contributor Author

bkontur commented Feb 18, 2025

@bkontur it definitely needs improvements, as it was first attempt here, and never worked to test&iterate. Feel free to change it :)

the polkadot-sdk one is a bit more advanced and stable

@mordamax
This is as far as I can go for now: paritytech/polkadot-sdk#7602 😃

@bkontur
Copy link
Contributor Author

bkontur commented Feb 22, 2025

/cmd bench --runtime coretime-polkadot coretime-polkadot --pallet pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic

@github-actions
Copy link

Command "" has started 🚀 See logs here

@github-actions
Copy link

Command "" has finished ✅ See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Feb 22, 2025

/cmd bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic

@github-actions
Copy link

Command "" has started 🚀 See logs here

@github-actions
Copy link

Command "" has finished ✅ See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Feb 22, 2025

/cmd bench --runtime coretime-polkadot --pallet pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic

@github-actions
Copy link

Command "" has started 🚀 See logs here

@github-actions
Copy link

Command "" has finished ✅ See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Feb 22, 2025

/cmd bench --runtime coretime-polkadot --pallet pallet_xcm

@github-actions
Copy link

Command "bench --runtime coretime-polkadot --pallet pallet_xcm" has started 🚀 See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Mar 14, 2025

Why? Did we had any failing tests because of this?

Well, basically, the opposite :), maybe we have a failing test with post_upgrade, and we don't know about it because of this issue - fortunately, we don't have any right now.

@bkontur bkontur mentioned this pull request Mar 31, 2025
3 tasks
@bkontur bkontur changed the title Disable MBM migrations for all runtimes for check-migrations CI Remove migrations ..v1.4.2 + disable MBM migrations for all runtimes for check-migrations CI Apr 3, 2025
@bkontur bkontur changed the title Remove migrations ..v1.4.2 + disable MBM migrations for all runtimes for check-migrations CI Remove migrations ..v1.4.2 + disable MBM migrations for all runtimes for check-migrations CI Apr 3, 2025
@bkontur
Copy link
Contributor Author

bkontur commented Apr 3, 2025

/cmd fmt

@bkontur bkontur mentioned this pull request Apr 3, 2025
3 tasks
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

Command "fmt" has started 🚀 See logs here

@github-actions
Copy link

github-actions bot commented Apr 3, 2025

Command "fmt" has finished ✅ See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Apr 3, 2025

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit a186a8e into polkadot-fellows:main Apr 3, 2025
63 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@bkontur bkontur deleted the bko-migrations branch April 4, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants