Snowbridge: Add support for Ether #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Doesn't look good, new crates bring new minor or major versions of deps, doesn't build. I see the snowfork crates have semver-minor bump, I expected patch bumps to have everything working ok. |
alistair-singh
force-pushed
the
alistair/support-native-ether
branch
2 times, most recently
from
61541b1 to
d46f577
Compare
yrong
reviewed
Jan 24, 2025
integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs
Show resolved
Hide resolved
yrong
reviewed
Jan 24, 2025
integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
yrong
reviewed
Jan 24, 2025
integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
|
Review required! Latest push from author must always be reviewed |
claravanstaden
approved these changes
Jan 24, 2025
Contributor
claravanstaden
left a comment
claravanstaden
left a comment
There was a problem hiding this comment.
@alistair-singh adding ether does not require any runtime config, except the new snowbridge-router-primitives crate version, right?
Contributor
Author
No, we just need the new code in the crate which interprets |
bkontur
reviewed
Jan 24, 2025
integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
bkontur
reviewed
Jan 24, 2025
integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
bkontur
reviewed
Jan 24, 2025
integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
bkontur
reviewed
Jan 24, 2025
integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
bkontur
reviewed
Jan 24, 2025
integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
bkontur
reviewed
Jan 24, 2025
integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
bkontur
reviewed
Jan 24, 2025
integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs
Show resolved
Hide resolved
bkontur
reviewed
Jan 24, 2025
integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
bkontur
approved these changes
Jan 24, 2025
franciscoaguirre
approved these changes
Jan 24, 2025
acatangiu
approved these changes
Jan 28, 2025
This reverts commit 2ea7fd3.
Co-authored-by: Adrian Catangiu <[email protected]>
alistair-singh
force-pushed
the
alistair/support-native-ether
branch
from
e2f6f99 to
5da0c64
Compare
acatangiu
approved these changes
Jan 29, 2025
eskimor
approved these changes
Jan 29, 2025
Contributor
|
/merge |
Contributor
|
Enabled Available commands
For more information see the documentation |
claravanstaden
approved these changes
Jan 31, 2025
acatangiu
approved these changes
Jan 31, 2025
fellowship-merge-bot
bot
merged commit 76d1fa6
into
polkadot-fellows:main
50 of 51 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the bridging Ether.
TODO
2409-10.16.1