Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nominee decentralization: How decentralized is your nomination? #2185

Merged
merged 34 commits into from
Jul 8, 2024

Conversation

rossbulat
Copy link
Collaborator

@rossbulat rossbulat commented Jul 7, 2024

Polish for the decentralization feature provided by PolkaWatch in #2160.

  • Abstracted Node component for GeoNomination list items.
  • Added RewardShare label to library.
  • Used ListItem/Wrapper and removed NominationGeoList/Wrapper to save on duplication.
  • Removes list formatting for consistency with rest of inner card lists on Nominate and Pools pages.
  • Re-org stat boxes, added label.
  • Add "not nominating" UI in Decentralisation tab when !isNominating().
  • useEffects fire on active account / network / isNominating() changes also.
  • Small formatting & locale changes.
  • Hides Nominate tabs if Polkawatch plugin is disabled.

Thanks to @rvalle and PolkaWatch for this feature!

@rossbulat rossbulat changed the title feat: Polish / Iteration for #2160 feat: Polish / Iteration for #2160 [WIP] Jul 7, 2024
src/locale/cn/pages.json Outdated Show resolved Hide resolved
src/locale/cn/pages.json Outdated Show resolved Hide resolved
src/locale/en/help.json Outdated Show resolved Hide resolved
src/locale/en/help.json Outdated Show resolved Hide resolved
src/locale/en/help.json Outdated Show resolved Hide resolved
src/locale/en/help.json Outdated Show resolved Hide resolved
@rossbulat rossbulat changed the title feat: Polish / Iteration for #2160 [WIP] feat: Polish / Iteration 1, for #2160 Jul 7, 2024
@rossbulat rossbulat changed the title feat: Polish / Iteration 1, for #2160 feat: Polish / Iteration for #2160 Jul 7, 2024
@rossbulat rossbulat changed the title feat: Polish / Iteration for #2160 feat: Nominee decentralization: How decentralized is your nomination? Jul 8, 2024
@rossbulat rossbulat merged commit 7dd170a into main Jul 8, 2024
7 checks passed
@rossbulat rossbulat deleted the rb-decentralization-polish branch July 8, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants