Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tablist-mode-map dynamically inherit from tablist-minor-mode-map #8

Open
Tracked by #1
DamienCassou opened this issue Jun 7, 2018 · 0 comments
Open
Tracked by #1

Comments

@DamienCassou
Copy link

The package has code like this:

(defvar tablist-mode-map
  (let ((kmap (copy-keymap tablist-minor-mode-map)))
    (set-keymap-parent kmap tabulated-list-mode-map)

As far as I understand, this means that if the user adds his bindings to tablist-minor-mode-map, they won't be added to tablist-mode-map. If you consider that a problem, you could rewrite your code that way (untested):

(defvar tablist-mode-map
  (let ((kmap (make-sparse-keymap)))
    (set-keymap-parent kmap (make-composed-keymap tablist-minor-mode-map tabulated-list-mode-map))

I'm not an expert so please double-check :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant