This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Update styleguide filtering #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdrewthis
commented
May 26, 2017
•
drewdrewthis
commented
- Refactors filtering to allow for a debouncing on the main section
- Adds autofocus for input
- Adds policygenius link and ©
- Updates some classnames for styles
drewdrewthis
force-pushed
the
update-styleguidist
branch
from
9d18c01 to
45f73a5
Compare
patrickskim
reviewed
May 26, 2017
| return ( | ||
| <div> | ||
| <div className={classes.root}> | ||
| <div className={classes.search}> | ||
| <input | ||
| ref={component => component && findDOMNode(component).focus()} |
There was a problem hiding this comment.
@patrickkim This autofocuses onto the input so that when you open RCL you can immediately start typing/filtering
patrickskim
reviewed
May 26, 2017
| // Updates Styleguidist state | ||
| // using updateSections function passed as prop | ||
| updateStyleguide = debounce((searchTerm, filteredSections, updateStyleguide) => { | ||
| updateStyleguide(searchTerm, filteredSections); |
There was a problem hiding this comment.
I found the semi circular nature of this part to be confusing. It would be helpful if it were broken out.
updateStyleguide = debounce(functionName, 200);
There was a problem hiding this comment.
You might want to consider making this a class method.
There was a problem hiding this comment.
Wasn't able to get it to work any other way. Can revisit in a refactor.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.