Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONSENSUS] Create helper in consensus tests for waiting for FSM events #634

Closed
7 tasks
gokutheengineer opened this issue Mar 29, 2023 · 2 comments
Closed
7 tasks
Labels
consensus Consensus specific changes

Comments

@gokutheengineer
Copy link
Contributor

Objective

Create a helper function for waiting for FSM events in consensus tests.

Origin Document

Error

Goals

  • Ensure state sync tests show deterministic behavior.

Deliverable

  • Helper function WaitForFSMEvents for consensus tests.

Non-goals / Non-deliverables

  • Change business logic

General issue deliverables

  • Update the appropriate CHANGELOG(s)
  • Update any relevant local/global README(s)
  • Update relevant source code tree explanations
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @gokutheengineer
Co-Owners: @Olshansk

@gokutheengineer gokutheengineer added the consensus Consensus specific changes label Mar 29, 2023
@gokutheengineer gokutheengineer self-assigned this Mar 29, 2023
@Olshansk Olshansk moved this to Up Next in V1 Dashboard Mar 29, 2023
@Olshansk
Copy link
Member

@gokutheengineer I think this is a priority over leader election.

It could also be good candidate for the "shared testing utilities" @bryanchriswhite is working on.

@jessicadaugherty jessicadaugherty moved this from Up Next to In Progress in V1 Dashboard Apr 5, 2023
@gokutheengineer gokutheengineer moved this from In Progress to In Review in V1 Dashboard Apr 19, 2023
@Olshansk Olshansk moved this from In Review to Rescope in V1 Dashboard Jul 10, 2023
@Olshansk
Copy link
Member

As we will likely be removing the FSM, I'm closing this out for now

@github-project-automation github-project-automation bot moved this from Rescope to Done in V1 Dashboard Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Consensus specific changes
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants