-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Uncompressed Inline tar cmd #1597
Conversation
`Uncompressed Inline` section's `tar` command had a flag for gzip files even though that archive is uncompressed. This changes it to `tar -xv` instead.
This pull request has been mentioned on Pocket Network Forum. There might be relevant details there: https://forum.pokt.network/t/under-review-simplify-infrastructure-deployment-and-operations/5022/1 |
doc/guides/snapshot.md
Outdated
@@ -59,7 +59,7 @@ The below snippet will download and extract the snapshot inline. This may be ben | |||
```bash | |||
wget -O latest.txt https://pocket-snapshot.liquify.com/files/latest.txt | |||
latestFile=$(cat latest.txt) | |||
wget -c "https://pocket-snapshot.liquify.com/files/$latestFile" -O - | sudo tar -xz -C {POCKET_DATA_DIR} | |||
wget -c "https://pocket-snapshot.liquify.com/files/$latestFile" -O - | sudo tar -xv -C {POCKET_DATA_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add more changes like this?
[ -d ${POCKET_DATA_DIR} ] || mkdir -p ${POCKET_DATA_DIR}
wget -c "https://pocket-snapshot.liquify.com/files/$(curl -s https://pocket-snapshot.liquify.com/files/latest.txt)" -O - \
| tar -xv -C ${POCKET_DATA_DIR}
- Missing dollar sign in front of {POCKET_DATA_DIR}
- No need to download latest.txt as a file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to do that, I'll push changes in a bit.
By the way, I've been working on a script that consolidates some of the steps here and in the OPERATE A NODE docs, would love to get your take on it if you're interested: https://github.com/0xThresh/pokt-node-setup/blob/pulumi-demo/node-setup.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, I've been working on a script that consolidates some of the steps here and in the OPERATE A NODE docs, would love to get your take on it if you're interested: https://github.com/0xThresh/pokt-node-setup/blob/pulumi-demo/node-setup.sh
Thank you for making this effort. I like this approach with a single script. Why don't you integrate your script to the top page of the tutorial? You can simply add a new section like "Quick script to set up a new node" above or below the "Manual Setup Tutorial" section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this effort. I like this approach with a single script. Why don't you integrate your script to the top page of the tutorial? You can simply add a new section like "Quick script to set up a new node" above or below the "Manual Setup Tutorial" section.
Glad to hear you like it! I have a bit more testing to do before I submit that; the nginx server isn't coming up correctly yet and I need to add pocket accounts. I'll keep working on it and submit a new PR once I get further along.
I'm also wondering how much of this stays relevant with Shannon. Do you know if there are big changes to the node setup process for Shannon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been mentioned on Pocket Network Forum. There might be relevant details there: https://forum.pokt.network/t/under-review-simplify-infrastructure-deployment-and-operations/5022/15 |
Sorry, I forgot to click the merge button. It's done now. |
## Description `Uncompressed Inline` section's `tar` command had a flag for gzip files even though that archive is uncompressed. This changes it to `tar -xv` instead so it doesn't error out. reviewpad:summary
Description
Uncompressed Inline
section'star
command had a flag for gzip files even though that archive is uncompressed. This changes it totar -xv
instead so it doesn't error out.reviewpad:summary