Fix onkeydown definition. (#35)

mbrandonw · web-flow · commit b1b59b3c48b6 · 2019-02-04T19:41:43.000-05:00
diff --git a/Sources/Html/Events.swift b/Sources/Html/Events.swift
@@ -438,7 +438,7 @@ public func oninvalid(unsafe javascript: String) -> Attribute<Tag.Input> {
 ///
 /// - Parameter javascript: JavaScript to execute.
 public func onkeydown<T>(_ javascript: StaticString) -> Attribute<T> {
-  return onkeyup(unsafe: String(describing: javascript))
+  return onkeydown(unsafe: String(describing: javascript))
 }
 
 /// Execute JavaScript when a user is pressing a key.
diff --git a/Tests/HtmlTests/EventsTests.swift b/Tests/HtmlTests/EventsTests.swift
@@ -180,7 +180,7 @@ final class EventsTests: XCTestCase {
 
     XCTAssertEqual(
       """
-<audio onabort="alert('Abort');" onabort="alert('Abort');" oncanplay="alert();" oncanplay="alert();" oncanplaythrough="alert();" oncanplaythrough="alert();" ondurationchange="alert();" ondurationchange="alert();" onemptied="alert();" onemptied="alert();" onended="alert();" onended="alert();" onerror="alert();" onerror="alert();" onloadeddata="alert();" onloadeddata="alert();" onloadedmetadata="alert();" onloadedmetadata="alert();" onloadstart="alert();" onloadstart="alert();" onpause="alert();" onpause="alert();" onplay="alert();" onplay="alert();" onplaying="alert();" onplaying="alert();" onseeked="alert();" onseeked="alert();" onseeking="alert();" onseeking="alert();" onstalled="alert();" onstalled="alert();" onprogress="alert();" onprogress="alert();" onratechange="alert();" onratechange="alert();" onsuspend="alert();" onsuspend="alert();" ontimeupdate="alert();" ontimeupdate="alert();" onvolumechange="alert();" onvolumechange="alert();" onwaiting="alert();" onwaiting="alert();"><track src="track" oncuechange="alert();" oncuechange="alert();"></audio><details ontoggle="alert();" ontoggle="alert();"></details><div onblur="alert();" onblur="alert();" onclick="alert();" onclick="alert();" oncontextmenu="alert();" oncontextmenu="alert();" oncopy="alert();" oncopy="alert();" oncut="alert();" oncut="alert();" ondblclick="alert();" ondblclick="alert();" ondrag="alert();" ondrag="alert();" ondragend="alert();" ondragend="alert();" ondragenter="alert();" ondragenter="alert();" ondragover="alert();" ondragover="alert();" ondragstart="alert();" ondragstart="alert();" ondrop="alert();" ondrop="alert();" onfocus="alert();" onfocus="alert();" onkeyup="alert();" onkeydown="alert();" onkeypress="alert();" onkeypress="alert();" onkeyup="alert();" onkeyup="alert();" onmousedown="alert();" onmousedown="alert();" onmousemove="alert();" onmousemove="alert();" onmouseout="alert();" onmouseout="alert();" onmouseover="alert();" onmouseover="alert();" onmouseup="alert();" onmouseup="alert();" onpaste="alert();" onpaste="alert();" onscroll="alert();" onscroll="alert();" onwheel="alert();" onwheel="alert();"></div><form onreset="alert();" onreset="alert();" onsubmit="alert();" onsubmit="alert();"></form><html><body onafterprint="alert();" onafterprint="alert();" onbeforeprint="alert();" onbeforeprint="alert();" onbeforeunload="alert();" onbeforeunload="alert();" onhashchange="alert();" onhashchange="alert();" onload="alert();" onload="alert();" onmessage="alert();" onmessage="alert();" onoffline="alert();" onoffline="alert();" ononline="alert();" ononline="alert();" onpagehide="alert();" onpagehide="alert();" onpageshow="alert();" onpageshow="alert();" onpopstate="alert();" onpopstate="alert();" onresize="alert();" onresize="alert();" onstorage="alert();" onstorage="alert();" onunload="alert();" onunload="alert();"></body></html><input onchange="alert();" onchange="alert();" oninput="alert();" oninput="alert();" oninvalid="alert();" oninvalid="alert();" onsearch="alert();" onsearch="alert();" onselect="alert();" onselect="alert();">
+<audio onabort="alert('Abort');" onabort="alert('Abort');" oncanplay="alert();" oncanplay="alert();" oncanplaythrough="alert();" oncanplaythrough="alert();" ondurationchange="alert();" ondurationchange="alert();" onemptied="alert();" onemptied="alert();" onended="alert();" onended="alert();" onerror="alert();" onerror="alert();" onloadeddata="alert();" onloadeddata="alert();" onloadedmetadata="alert();" onloadedmetadata="alert();" onloadstart="alert();" onloadstart="alert();" onpause="alert();" onpause="alert();" onplay="alert();" onplay="alert();" onplaying="alert();" onplaying="alert();" onseeked="alert();" onseeked="alert();" onseeking="alert();" onseeking="alert();" onstalled="alert();" onstalled="alert();" onprogress="alert();" onprogress="alert();" onratechange="alert();" onratechange="alert();" onsuspend="alert();" onsuspend="alert();" ontimeupdate="alert();" ontimeupdate="alert();" onvolumechange="alert();" onvolumechange="alert();" onwaiting="alert();" onwaiting="alert();"><track src="track" oncuechange="alert();" oncuechange="alert();"></audio><details ontoggle="alert();" ontoggle="alert();"></details><div onblur="alert();" onblur="alert();" onclick="alert();" onclick="alert();" oncontextmenu="alert();" oncontextmenu="alert();" oncopy="alert();" oncopy="alert();" oncut="alert();" oncut="alert();" ondblclick="alert();" ondblclick="alert();" ondrag="alert();" ondrag="alert();" ondragend="alert();" ondragend="alert();" ondragenter="alert();" ondragenter="alert();" ondragover="alert();" ondragover="alert();" ondragstart="alert();" ondragstart="alert();" ondrop="alert();" ondrop="alert();" onfocus="alert();" onfocus="alert();" onkeydown="alert();" onkeydown="alert();" onkeypress="alert();" onkeypress="alert();" onkeyup="alert();" onkeyup="alert();" onmousedown="alert();" onmousedown="alert();" onmousemove="alert();" onmousemove="alert();" onmouseout="alert();" onmouseout="alert();" onmouseover="alert();" onmouseover="alert();" onmouseup="alert();" onmouseup="alert();" onpaste="alert();" onpaste="alert();" onscroll="alert();" onscroll="alert();" onwheel="alert();" onwheel="alert();"></div><form onreset="alert();" onreset="alert();" onsubmit="alert();" onsubmit="alert();"></form><html><body onafterprint="alert();" onafterprint="alert();" onbeforeprint="alert();" onbeforeprint="alert();" onbeforeunload="alert();" onbeforeunload="alert();" onhashchange="alert();" onhashchange="alert();" onload="alert();" onload="alert();" onmessage="alert();" onmessage="alert();" onoffline="alert();" onoffline="alert();" ononline="alert();" ononline="alert();" onpagehide="alert();" onpagehide="alert();" onpageshow="alert();" onpageshow="alert();" onpopstate="alert();" onpopstate="alert();" onresize="alert();" onresize="alert();" onstorage="alert();" onstorage="alert();" onunload="alert();" onunload="alert();"></body></html><input onchange="alert();" onchange="alert();" oninput="alert();" oninput="alert();" oninvalid="alert();" oninvalid="alert();" onsearch="alert();" onsearch="alert();" onselect="alert();" onselect="alert();">
 """,
       render(doc)
     )

Original file line number	Diff line number	Diff line change
`@@ -438,7 +438,7 @@ public func oninvalid(unsafe javascript: String) -> Attribute<Tag.Input> {`
`438`	`438`	`///`
`439`	`439`	`/// - Parameter javascript: JavaScript to execute.`
`440`	`440`	`public func onkeydown<T>(_ javascript: StaticString) -> Attribute<T> {`
`441`		`- return onkeyup(unsafe: String(describing: javascript))`
	`441`	`+ return onkeydown(unsafe: String(describing: javascript))`
`442`	`442`	`}`
`443`	`443`
`444`	`444`	`/// Execute JavaScript when a user is pressing a key.`
Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ final class EventsTests: XCTestCase {`
`180`	`180`
`181`	`181`	`XCTAssertEqual(`
`182`	`182`	`"""`
`183`		-<audio onabort="alert('Abort');" onabort="alert('Abort');" oncanplay="alert();" oncanplay="alert();" oncanplaythrough="alert();" oncanplaythrough="alert();" ondurationchange="alert();" ondurationchange="alert();" onemptied="alert();" onemptied="alert();" onended="alert();" onended="alert();" onerror="alert();" onerror="alert();" onloadeddata="alert();" onloadeddata="alert();" onloadedmetadata="alert();" onloadedmetadata="alert();" onloadstart="alert();" onloadstart="alert();" onpause="alert();" onpause="alert();" onplay="alert();" onplay="alert();" onplaying="alert();" onplaying="alert();" onseeked="alert();" onseeked="alert();" onseeking="alert();" onseeking="alert();" onstalled="alert();" onstalled="alert();" onprogress="alert();" onprogress="alert();" onratechange="alert();" onratechange="alert();" onsuspend="alert();" onsuspend="alert();" ontimeupdate="alert();" ontimeupdate="alert();" onvolumechange="alert();" onvolumechange="alert();" onwaiting="alert();" onwaiting="alert();"><track src="track" oncuechange="alert();" oncuechange="alert();"></audio><details ontoggle="alert();" ontoggle="alert();"></details><div onblur="alert();" onblur="alert();" onclick="alert();" onclick="alert();" oncontextmenu="alert();" oncontextmenu="alert();" oncopy="alert();" oncopy="alert();" oncut="alert();" oncut="alert();" ondblclick="alert();" ondblclick="alert();" ondrag="alert();" ondrag="alert();" ondragend="alert();" ondragend="alert();" ondragenter="alert();" ondragenter="alert();" ondragover="alert();" ondragover="alert();" ondragstart="alert();" ondragstart="alert();" ondrop="alert();" ondrop="alert();" onfocus="alert();" onfocus="alert();" onkeyup="alert();" onkeydown="alert();" onkeypress="alert();" onkeypress="alert();" onkeyup="alert();" onkeyup="alert();" onmousedown="alert();" onmousedown="alert();" onmousemove="alert();" onmousemove="alert();" onmouseout="alert();" onmouseout="alert();" onmouseover="alert();" onmouseover="alert();" onmouseup="alert();" onmouseup="alert();" onpaste="alert();" onpaste="alert();" onscroll="alert();" onscroll="alert();" onwheel="alert();" onwheel="alert();"></div><form onreset="alert();" onreset="alert();" onsubmit="alert();" onsubmit="alert();"></form><html><body onafterprint="alert();" onafterprint="alert();" onbeforeprint="alert();" onbeforeprint="alert();" onbeforeunload="alert();" onbeforeunload="alert();" onhashchange="alert();" onhashchange="alert();" onload="alert();" onload="alert();" onmessage="alert();" onmessage="alert();" onoffline="alert();" onoffline="alert();" ononline="alert();" ononline="alert();" onpagehide="alert();" onpagehide="alert();" onpageshow="alert();" onpageshow="alert();" onpopstate="alert();" onpopstate="alert();" onresize="alert();" onresize="alert();" onstorage="alert();" onstorage="alert();" onunload="alert();" onunload="alert();"></body></html><input onchange="alert();" onchange="alert();" oninput="alert();" oninput="alert();" oninvalid="alert();" oninvalid="alert();" onsearch="alert();" onsearch="alert();" onselect="alert();" onselect="alert();">
	`183`	+<audio onabort="alert('Abort');" onabort="alert('Abort');" oncanplay="alert();" oncanplay="alert();" oncanplaythrough="alert();" oncanplaythrough="alert();" ondurationchange="alert();" ondurationchange="alert();" onemptied="alert();" onemptied="alert();" onended="alert();" onended="alert();" onerror="alert();" onerror="alert();" onloadeddata="alert();" onloadeddata="alert();" onloadedmetadata="alert();" onloadedmetadata="alert();" onloadstart="alert();" onloadstart="alert();" onpause="alert();" onpause="alert();" onplay="alert();" onplay="alert();" onplaying="alert();" onplaying="alert();" onseeked="alert();" onseeked="alert();" onseeking="alert();" onseeking="alert();" onstalled="alert();" onstalled="alert();" onprogress="alert();" onprogress="alert();" onratechange="alert();" onratechange="alert();" onsuspend="alert();" onsuspend="alert();" ontimeupdate="alert();" ontimeupdate="alert();" onvolumechange="alert();" onvolumechange="alert();" onwaiting="alert();" onwaiting="alert();"><track src="track" oncuechange="alert();" oncuechange="alert();"></audio><details ontoggle="alert();" ontoggle="alert();"></details><div onblur="alert();" onblur="alert();" onclick="alert();" onclick="alert();" oncontextmenu="alert();" oncontextmenu="alert();" oncopy="alert();" oncopy="alert();" oncut="alert();" oncut="alert();" ondblclick="alert();" ondblclick="alert();" ondrag="alert();" ondrag="alert();" ondragend="alert();" ondragend="alert();" ondragenter="alert();" ondragenter="alert();" ondragover="alert();" ondragover="alert();" ondragstart="alert();" ondragstart="alert();" ondrop="alert();" ondrop="alert();" onfocus="alert();" onfocus="alert();" onkeydown="alert();" onkeydown="alert();" onkeypress="alert();" onkeypress="alert();" onkeyup="alert();" onkeyup="alert();" onmousedown="alert();" onmousedown="alert();" onmousemove="alert();" onmousemove="alert();" onmouseout="alert();" onmouseout="alert();" onmouseover="alert();" onmouseover="alert();" onmouseup="alert();" onmouseup="alert();" onpaste="alert();" onpaste="alert();" onscroll="alert();" onscroll="alert();" onwheel="alert();" onwheel="alert();"></div><form onreset="alert();" onreset="alert();" onsubmit="alert();" onsubmit="alert();"></form><html><body onafterprint="alert();" onafterprint="alert();" onbeforeprint="alert();" onbeforeprint="alert();" onbeforeunload="alert();" onbeforeunload="alert();" onhashchange="alert();" onhashchange="alert();" onload="alert();" onload="alert();" onmessage="alert();" onmessage="alert();" onoffline="alert();" onoffline="alert();" ononline="alert();" ononline="alert();" onpagehide="alert();" onpagehide="alert();" onpageshow="alert();" onpageshow="alert();" onpopstate="alert();" onpopstate="alert();" onresize="alert();" onresize="alert();" onstorage="alert();" onstorage="alert();" onunload="alert();" onunload="alert();"></body></html><input onchange="alert();" onchange="alert();" oninput="alert();" oninput="alert();" oninvalid="alert();" oninvalid="alert();" onsearch="alert();" onsearch="alert();" onselect="alert();" onselect="alert();">
`184`	`184`	`""",`
`185`	`185`	`render(doc)`
`186`	`186`	`)`