@DependencyClient and inout parameters

[Alex293]

Description

The code generated by @DependencyClient is incorrect for inout parameters and generate invalid swift code. it should explicitly refuse to generate code or if possible generate valid code.

Checklist

• I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
• If possible, I've reproduced the issue using the main branch of this package.
• This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior

@DependencyClient
public struct AuthenticationClient {
    var authenticateRequest: (_ urlRequest: inout URLRequest) async throws  -> Void
}

Should generate valid swift code

Actual behavior

The code generated :

func authenticateRequest(urlRequest p0: inout URLRequest) async throws  -> Void {
    try await self.authenticateRequest(p0)
}

private var _authenticateRequest: (_ urlRequest: inout URLRequest) async throws  -> Void = { _ in
    XCTestDynamicOverlay.XCTFail("Unimplemented: 'authenticateRequest'")
    throw DependenciesMacros.Unimplemented("authenticateRequest")
}

is not valid code: Passing value of type 'URLRequest' to an inout parameter requires explicit '&'

Steps to reproduce

No response

Dependencies version information

1.1.1

Destination operating system

No response

Xcode version information

15.0.1

Swift Compiler version information

No response

[mbrandonw]

Hey @Alex293, good catch! Do you have any interest in diving into this and trying to fix it? No worries if not, we will take a look soon.

[Alex293]

I'd love to. I'll have a look within a couple days and ping you if I'm struggling, Idon't have much experience with SwiftSyntax but I was looking to dive in.