Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation instructions should prefer asset library #33

Closed
nathanfranke opened this issue Jul 4, 2022 · 1 comment · Fixed by #34
Closed

Installation instructions should prefer asset library #33

nathanfranke opened this issue Jul 4, 2022 · 1 comment · Fixed by #34
Milestone
1.3.1

Comments

@nathanfranke
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Manual installation is unnecessary, since the asset library is built in and is usually up to date

Describe the solution you'd like
I would just swap around the instructions in the README and add a note that the manual installation is only needed if you are using bleeding edge versions.

Describe alternatives you've considered
.

Additional context
.
@nathanfranke nathanfranke mentioned this issue Jul 4, 2022
Merged
@gumaciel
Copy link
Contributor

gumaciel commented Jul 4, 2022

Thank you! I believe that once your PR is approved it will solve this problem

@gumaciel gumaciel added this to the 1.3.1 milestone Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.1
Development

Successfully merging a pull request may close this issue.

improve readme, improve .gitattributes nathanfranke/godot-admob-editor
2 participants
@nathanfranke @gumaciel