Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql query of Vulcan withList HOC is stuck with loading = true forever #1

Open
pohsunhuang opened this issue Mar 30, 2018 · 0 comments
Labels

Comments

@pohsunhuang
Copy link
Owner

Bug Description

There are many cases can trigger this one. e.g. Search topic for two times with different search text that both has zero search result, the second query will be stuck with loading = true and networkStatus = 1 forever.

Possible Root Cause

It's a apollo-client bug according to the community, might be fixed in V2.2.8.

Workaround

Apply following graphql option within Vulcan withList HOC

notifyOnNetworkStatusChange: true

withList HOC does not provide direct access to graphql option, we have three ways to do it:

  1. Put it directly into withList.js
  2. Modify Vulcan's package.json to use apollo-client beyond V2.2.8
  3. Write my own version of withList

Reference

apollographql/apollo-client#1186
apollographql/react-apollo#1397
apollographql/react-apollo#1385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant