Handle parent directory as destination #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm open to the suggestion that I'm just doing this wrong :), but: The project I'm working with has multiple submodules. One of these modules (two subdirectories deep) we would like to publish with this tool to the gh-pages branch, but to the top-level directory on the gh-pages branch. E.g.: ``` ember github-pages:commit --message "Update gh-pages release" --destination ../../ ``` This fails in two places: * rm -rf ../.. is problematic; * mkdir ../.. complains that it's creating a directory that already exists To fix this I've added a regex that allows this case to be handled by the first condition of the branch.
|
Hi @knownasilya, is it possible to publish the changes here to npm? |
|
@jacobtolar on it |
|
Published as v0.2.2 with dependency updates |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm open to the suggestion that I'm just doing this wrong :), but:
The project I'm working with has multiple submodules. One of these modules (two subdirectories deep) we would like to publish with this tool to the gh-pages branch, but to the top-level directory on the gh-pages branch.
E.g.:
This fails in two places:
To fix this I've added a regex that allows this case to be handled by the first condition of the branch.