Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global zoom limitation and split tile's zoom and viewport zoom #110

Closed
noktoborus opened this issue Jan 5, 2024 · 6 comments · Fixed by #215
Closed

Remove global zoom limitation and split tile's zoom and viewport zoom #110

noktoborus opened this issue Jan 5, 2024 · 6 comments · Fixed by #215

Comments

@noktoborus
Copy link
Contributor

E.g. walkers can draw scaled z19 tiles on z21 even if source (like osm.org) not supported it.

This is convenient if different sources support different zoom and the way to support smooth zooming in future.

I made a stub partially covering my request but it is terrible solution: #101

@podusowski
Copy link
Owner

The idea seems sound, though I think I would start with a min/max pair (say struct ZoomLevels) which is returned from Tiles. Also, your PR is mixed with this click branch, which I don't really know what to do with it. It kind of breaks the idea of my_position, which would typically be a position obtained from the GPS or something and provided by the app. And if app wanted to jump somewhere, you'd call MapMemory::center_at (might want to rename to jump_to when I think about it now :)).

@podusowski
Copy link
Owner

Getting position under the mouse is a nice example though.

@noktoborus
Copy link
Contributor Author

Also, your PR is mixed with this click branch,

I will drop zoom branch.

which I don't really know what to do with it. It kind of breaks the idea of my_position

Now no one provide GPS data, so I assume what click to set position is good idea.

I have reworked the click branch, could you take a look? :)

@podusowski
Copy link
Owner

Now no one provide GPS data

I'm thinking about adding it to the demo soon.

@podusowski
Copy link
Owner

This is all I see there.

image

@noktoborus
Copy link
Contributor Author

This is all I see there.

sorry, I forgot to commit the new changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants