Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close button added to Confirmation Dialog #1934

Merged

Conversation

viiktorstefanov
Copy link
Contributor

@viiktorstefanov viiktorstefanov commented Sep 15, 2024

Closes #issue-1830

Motivation and context

Screenshots:

Desktop layout:
Screenshot 2024-09-15 at 20-27-02 Подкрепи бг

Mobile layout:
Screenshot 2024-09-15 at 20-27-39 Подкрепи бг

Before After
Paste screenshot Paste screenshot

Testing

Steps to test

Affected urls

Environment

New environment variables:

  • NEW_ENV_VAR: env var details

New or updated dependencies:

Dependency name Previous version Updated version Details
dependency/name v1.0.0 v2.0.0

Copy link

github-actions bot commented Sep 15, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

@ani-kalpachka ani-kalpachka added the run tests Allows running the tests workflows for forked repos label Sep 17, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Sep 17, 2024
@ani-kalpachka ani-kalpachka linked an issue Sep 17, 2024 that may be closed by this pull request
@ani-kalpachka ani-kalpachka merged commit ddae62f into podkrepi-bg:master Sep 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing close button in modal window.
2 participants