Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stripe-connection-bug - add retry logic to the donation mutation #1390

Merged

Conversation

dimitur2204
Copy link
Contributor

@dimitur2204 dimitur2204 commented Mar 16, 2023

Motivation and context

Since there are problems with connection to Stripe and sometimes 2 or 3 requests are required before a checkout session is created successfully (detailed issue here), retry logic would be useful.

Testing

Tested with a failed request locally and the logic works as described in the retry method

Affected urls

/campaigns/donation/{slug}

@github-actions
Copy link

github-actions bot commented Mar 16, 2023

✅ Tests will run for this PR. Once they succeed it can be merged.

@dimitur2204 dimitur2204 added the run tests Allows running the tests workflows for forked repos label Mar 16, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Mar 16, 2023
Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid!

@dimitur2204 dimitur2204 merged commit cb97449 into podkrepi-bg:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants