Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline styles ("style={{ ... }}" attribute) #1894

Open
ani-kalpachka opened this issue Aug 7, 2024 · 0 comments
Open

Remove inline styles ("style={{ ... }}" attribute) #1894

ani-kalpachka opened this issue Aug 7, 2024 · 0 comments
Labels
type: enhancement New feature or request

Comments

@ani-kalpachka
Copy link
Member

ani-kalpachka commented Aug 7, 2024

Describe the feature you'd like to request

We should remove the inlined "style={{}}" attribute from our code.

  • It happened to cause unwanted behaviour.
  • We need to be consistent in the way we apply styles. Currently we do it with styled (https://mui.com/system/styled/) or with the sx property (https://mui.com/system/getting-started/the-sx-prop/).
  • It is not cosidered a good practice in sense of maintainability, reusability, performance, consistency, caching, speed, debugging.
  • It is generally considered outdated.

Describe the solution you'd like

We can use styled and sx prop to adhere to the Material UI best practices of styling.

@ani-kalpachka ani-kalpachka added the type: enhancement New feature or request label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant