#464 - Add check for an existing person and connect before updating donation
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
dimitur2204
requested review from
igoychev and
slavcho
and removed request for
igoychev
dimitur2204
added
the
run tests
github-actions
bot
removed
the
run tests
dimitur2204
changed the title
person and connect before updating donation
igoychev
requested changes
Mar 17, 2023
| @@ -497,11 +505,10 @@ export class CampaignService { | |||
| ) | |||
| throw new InternalServerErrorException(error) | |||
| } | |||
|
|
|||
| return | |||
There was a problem hiding this comment.
the bug is actually on this line:
If the Charge.succeeded event is sent first from Stripe - this 'return' here will skip the connection of the donation to the user by mail.
Comment on lines
-541
to
-563
| //For successful donations we will also need to link them to user and add donation wish: | ||
| if (newDonationStatus === DonationStatus.succeeded) { | ||
| Logger.debug('metadata?.isAnonymous = ' + metadata?.isAnonymous) | ||
|
|
||
| if (metadata?.isAnonymous != 'true') { | ||
| await this.prisma.donation.update({ | ||
| where: { id: donation.id }, | ||
| data: { | ||
| person: { | ||
| connect: { | ||
| email: paymentData.billingEmail, | ||
| }, | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| Logger.debug('Saving donation wish ' + metadata?.wish) | ||
|
|
||
| if (metadata?.wish) { | ||
| await this.createDonationWish(metadata.wish, donation.id, campaign.id) | ||
| } | ||
| } |
There was a problem hiding this comment.
The removed code was intended to be executed for Charge.Succeeded event so that only then to save the donation wish. Unfortunately moving it above doesn't guarantee that. So, please see my comment above that the actual bug is because this code is skipped by the forgotten 'return' on line 500.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #464
Motivation and context
Quick fix to check if a person exists and then connect to the donation accordingly.
This whole flow needs revisiting and will be addressed in #466
Testing
Tested out the whole flow for both logged, anonymous and not logged and it is working as expected