Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Race Condition" potential in setup flow #19

Open
houllette opened this issue Sep 1, 2022 · 0 comments
Open

"Race Condition" potential in setup flow #19

houllette opened this issue Sep 1, 2022 · 0 comments
Assignees
Labels
bug Something isn't working technical optimization Improvements to how the ESCT deploys and/or works "under the hood"

Comments

@houllette
Copy link
Collaborator

If the purposed architecture for autograding is to have the grader run on all MRs to main branch, it will block folks who are trying to make adjustments to the curriculum before having engineers in their company run it themselves.

So a break glass would need to be made in the grader job to allow for bypassing it (which is also useful for bugs in grading to not cause undo problems on participants), but we need to be careful not to introduce a hole so folks who aren't passing the test can just bypass it without completing the training (especially if the training is being used for compliance purposes).

@houllette houllette added bug Something isn't working technical optimization Improvements to how the ESCT deploys and/or works "under the hood" labels Sep 1, 2022
@houllette houllette self-assigned this Feb 1, 2023
@houllette houllette added this to the 1.0 - General Release milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical optimization Improvements to how the ESCT deploys and/or works "under the hood"
Development

No branches or pull requests

1 participant