style: adjustment

Author: podhmo

Makefile

@@ -6,6 +6,9 @@ test:
 lint:
 	golangci-lint run # -v --enable-all
 
+format:
+	goimports -w $(shell git ls-files | grep ".go$$")
+
 # example (for testing)
 httpbin:
 	cd examples/00httpbin && go run ./cmd/httpbin/main.go localhost:8080

integration_test.go

@@ -22,7 +22,7 @@ type Input struct {
 	Values []int
 }
 
-func Add(w http.ResponseWriter, req *http.Request) {
+func handleAdd(w http.ResponseWriter, req *http.Request) {
 	var data Input
 	decoder := json.NewDecoder(req.Body)
 	if err := decoder.Decode(&data); err != nil {
@@ -44,12 +44,12 @@ func Add(w http.ResponseWriter, req *http.Request) {
 
 func TestHandler(t *testing.T) {
 	t.Run("plain", func(t *testing.T) {
-		w := httptest.NewRecorder()
+		rec := httptest.NewRecorder()
 		req := httptest.NewRequest("POST", "/", bytes.NewBufferString(`{"values": [1,2,3]}`))
 		req.Header.Set("Content-Type", "application/json")
 
-		Add(w, req)
-		res := w.Result()
+		handleAdd(rec, req)
+		res := rec.Result()
 
 		if res.StatusCode != 200 {
 			b, _ := ioutil.ReadAll(res.Body)
@@ -70,7 +70,7 @@ func TestHandler(t *testing.T) {
 	})
 
 	t.Run("webtest", func(t *testing.T) {
-		c := webtest.NewClientFromHandler(http.HandlerFunc(Add))
+		c := webtest.NewClientFromHandler(http.HandlerFunc(handleAdd))
 		var want interface{}
 		got, err := c.Post("/",
 			webtest.WithJSONString(`{"values": [1,2,3]}`),
@@ -91,7 +91,7 @@ func TestHandler(t *testing.T) {
 	})
 
 	t.Run("try", func(t *testing.T) {
-		c := webtest.NewClientFromHandler(http.HandlerFunc(Add))
+		c := webtest.NewClientFromHandler(http.HandlerFunc(handleAdd))
 
 		var want interface{}
 		try.It{

readme.md

@@ -27,7 +27,7 @@ import (
 )
 
 func TestWithWebtest(t *testing.T) {
-	c := webtest.NewClientFromHandler(http.HandlerFunc(Add))
+	c := webtest.NewClientFromHandler(http.HandlerFunc(handleAdd))
 	var want interface{}
 	got, err := c.Post("/",
 		webtest.WithJSON(bytes.NewBufferString(`{"values": [1,2,3]}`)),
@@ -61,7 +61,7 @@ import (
 
 
 func TestWithTry(t *testing.T) {
-	c := webtest.NewClientFromHandler(http.HandlerFunc(Add))
+	c := webtest.NewClientFromHandler(http.HandlerFunc(handleAdd))
 
 	var want interface{}
 	try.It{
@@ -80,7 +80,7 @@ func TestWithTry(t *testing.T) {
 If modify response is not needed, it is also ok, when the response does not include *semi-random value* (for example the value of now time).
 
 ```go
-c := webtest.NewClientFromHandler(http.HandlerFunc(Add))
+c := webtest.NewClientFromHandler(http.HandlerFunc(handleAdd))
 
 var want interface{}
 try.It{
@@ -108,12 +108,12 @@ import (
 )
 
 func TestWithoutWebtest(t *testing.T) {
-	w := httptest.NewRecorder()
+	rec := httptest.NewRecorder()
 	req := httptest.NewRequest("POST", "/", bytes.NewBufferString(`{"values": [1,2,3]}`))
 	req.Header.Set("Content-Type", "application/json")
 
-	Add(w, req)
-	res := w.Result()
+	handleAdd(rec, req)
+	res := rec.Result()
 
 	if res.StatusCode != 200 {
 		b, _ := ioutil.ReadAll(res.Body)

testclient/response.go

@@ -21,11 +21,11 @@ type Response interface {
 
 	Raw() *http.Response
 
-// 	Extractor
-// }
+	// 	Extractor
+	// }
 
-// // Extractor :
-// type Extractor interface {
+	// // Extractor :
+	// type Extractor interface {
 	ParseJSONData(val interface{}) error
 	JSONData() interface{}