Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type mismatch and annotations #114

Open
danielfromearth opened this issue May 16, 2024 · 1 comment
Open

type mismatch and annotations #114

danielfromearth opened this issue May 16, 2024 · 1 comment

Comments

@danielfromearth
Copy link
Collaborator

danielfromearth commented May 16, 2024

The input file type seems to expected to be pathlib.Path on this line where a .name attribute is accessed. However, this file path type is annotated as str at the beginning of the merge function, here.

I believe the annotation should be changed to say a Path needs to be inputted, or the input path str could be converted to a Path during execution. Which would be preferred? Or other suggestions?

@jamesfwood
Copy link
Collaborator

Hi @danielfromearth
yeah I'd say go with the annotation to say Path needs to be inputted.

Also, we are going to make a release of this soon, so if you can update it then I can get it into the next release.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants