Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty file should show zero line count #1249

Open
arthur-star opened this issue Aug 8, 2019 · 1 comment
Open

Empty file should show zero line count #1249

arthur-star opened this issue Aug 8, 2019 · 1 comment

Comments

@arthur-star
Copy link

Description

Empty file should show zero line count

Versions and device

  • Android 9
  • PocketHub v0.5.1
  • HUAWEI MATE 10

Steps to Reproduce

  1. open an empty file -- for example

    https://github.com/arthur-star/Empty-demo/blob/master/zero-line

  2. the line count shows one, not zero

Actual behaviour

the line count shows one

Expected behaviour

the line count shows zero

@Meisolsson
Copy link
Contributor

I will try to fix this at a later point. The reason why it shows one line is that we are using the same library for editing and displaying code so I guess that they "add" one line so that you would have something to type on. We do set it to read only, but yeah.

I have been looking at alternatives but haven't found any good ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants