Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Add class="error to all to the errors <p> tags #789

Closed
dennis00010011b opened this issue Apr 10, 2018 · 0 comments
Closed

(Feature) Add class="error to all to the errors <p> tags #789

dennis00010011b opened this issue Apr 10, 2018 · 0 comments
Assignees

Comments

@dennis00010011b
Copy link

dennis00010011b commented Apr 10, 2018

Inspired by #767 (comment)

There is no way to find elements 'Error' on the page except use a xpath requests. But it is bad practice which leads to unstable e2e test.

Location where class="error still aren't added:

  1. Step 2: Reserved tokens - Address
  2. Step 2: Reserved tokens - Value
  3. Step 3: Whitelist-Address
  4. Step 3: Whitelist-Min
  5. Step 3: Whitelist-Max
  6. Step 3: Gasprice - Custom
  7. Manage page: Start time
  8. Manage page: End time
  9. Manage page: Rate
  10. Manage page: Supply
  11. Manage page: Whitelist- Address
  12. Manage page: Whitelist- Min
  13. Manage page: Whitelist- Max

@dennis00010011b dennis00010011b changed the title (Feature) Add class="error to all to the errors <p> tags (Feature) Add class="error to all to the errors <p> tags Apr 10, 2018
@dennis00010011b dennis00010011b changed the title (Feature) Add class="error to all to the errors <p> tags (Feature) Add class="error to all to the errors <p> tags Apr 10, 2018
@fernandomg fernandomg self-assigned this Apr 23, 2018
vbaranov referenced this issue Apr 24, 2018
@ghost ghost removed the in progress label Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants