Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) Decimals value is lost if user returns back from step3 to step2 #635

Closed
dennis00010011b opened this issue Feb 27, 2018 · 3 comments
Closed

Comments

@dennis00010011b
Copy link

dennis00010011b commented Feb 27, 2018

Related #632

Step to reproduce:

  1. Open wizard, go to step 2
  2. Fill out fields name, ticker, decimals
  3. Click button "Continue"
  4. Return back to step 2(click browser's button "Back" or keys "Alt+Left Arrow")
  5. Observe fields decimals
    Expected result :fields decimals should contain values which was entered (like field Name and Ticker)
    Actual result: fields decimals is empty.

If you are reporting a problem with Token Wizard, please include the following information:

Which network did you use? (Mainnet, Kovan, Rinkeby, etc.)

n/a

If you were able to create it, what is the URL of your crowdsale?

n/a

Do you have screenshots showing the problem?

https://drive.google.com/open?id=1YJ7AQGoRnsG0jqwe4lYBCqcTNxoSYN7E

Do you see errors in the dev console? If yes, please include a screenshot

To open the dev console in Google Chrome, press F12, or go to View -> Developer -> Developer Tools, and open the Console tab

If you see errors, please right click on them and "Save as..". Zip saved file and attach it to the Issue.

No


@dennis00010011b dennis00010011b changed the title (Bug) Decimals value and reserved list are lost if user returns back from step3 to step2 (Bug) Decimals value is lost if user returns back from step3 to step2 Feb 27, 2018
@fvictorio
Copy link
Contributor

I think a lot of things will break if you go back to a previous step.

@vbaranov Is this a feature that we should support? If not, maybe a simpler solution would be to just not allow going back (maybe by instructing react-router to not push the step pages to the history, if that's possible).

@vbaranov
Copy link
Collaborator

Is this a feature that we should support?

as we have no back button in Wizard UI we shouldn't support this feature, imo. But it would be user-friendly to switch between steps before deployment. I added this feature request: #637.

If not, maybe a simpler solution would be to just not allow going back (maybe by instructing react-router to not push the step pages to the history, if that's possible).

I am ok with this quick solution if it will work.

@fvictorio
Copy link
Contributor

Closing this in favor of #637.

@ghost ghost removed the to do label Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants