Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Add investment option without Metamask #319

Closed
2 tasks
igorbarinov opened this issue Nov 1, 2017 · 2 comments
Closed
2 tasks

(Feature) Add investment option without Metamask #319

igorbarinov opened this issue Nov 1, 2017 · 2 comments

Comments

@igorbarinov
Copy link
Member

Rationale
There are customers of ICO who don't have Metamask of other Web3-injected wallet installed. In this issue, we add an option of buying tokens without using web3 injected wallet

Implementation
A list box with investment methods is added. It has two options Metamask and QR. Metamask is the default option if Metamask is present.
image

If the Metamask option is selected then on Invest button web3 event triggered.
If QR is selected then this set of controls and views is presented
image

  • qr code. some research needs to be done:
    • check if QR code can have method id (data) embedded
    • check if QR code can have wallet and amount embedded
  • label with the worth of selected tokens in ETH
  • address
  • control to copy the address. The toast should appear after successful copying
  • progress bar. The page will poss crowdsale address for a number of tokens specified to invest on crowdsale contract. Should be a polling with 2(?) seconds
  • memo to use data (protection from sending from exchanges)

After poll will catch the event the view will be changed to
image

It's possible that polling will get someone else investment for the same amount. We can add an additional parameter to buy() which will be emitted into the blockchain log. @vbaranov what do you think?

@fvictorio
Copy link
Contributor

I think is better to start with a QR code just with the address. Encoding more information in a URI (that then can be converted to a QR) seems to be an open proposal: ethereum/EIPs#67.

@igorbarinov
Copy link
Member Author

I agree, let's start with the address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants