Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if address_id is binary in token_transfers_csv endpoint #2422

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 24, 2019

fixes

2019-07-22T23:24:15.080 [error] #PID<0.9115.250> running BlockScoutWeb.Endpoint (connection #PID<0.9292.250>, stream id 1) terminated
Request: GET /token_transfers_csv?address_id
** (exit) an exception was raised:
    ** (FunctionClauseError) no function clause matching in Explorer.Chain.string_to_address_hash/1
        (explorer) lib/explorer/chain.ex:2097: Explorer.Chain.string_to_address_hash(nil)
        (block_scout_web) lib/block_scout_web/controllers/address_transaction_controller.ex:114: BlockScoutWeb.AddressTransactionController.token_transfers_csv/2
        (block_scout_web) lib/block_scout_web/controllers/address_transaction_controller.ex:1: BlockScoutWeb.AddressTransactionController.action/2
        (block_scout_web) lib/block_scout_web/controllers/address_transaction_controller.ex:1: BlockScoutWeb.AddressTransactionController.phoenix_controller_pipeline/2
        (block_scout_web) lib/block_scout_web/endpoint.ex:1: BlockScoutWeb.Endpoint.instrument/4
        (phoenix) lib/phoenix/router.ex:275: Phoenix.Router.__call__/1
        (block_scout_web) lib/block_scout_web/endpoint.ex:1: BlockScoutWeb.Endpoint.plug_builder_call/2
        (block_scout_web) lib/block_scout_web/endpoint.ex:1: BlockScoutWeb.Endpoint."call (overridable 3)"/2

Changelog

  • check if address_id is binary in token_transfers_csv endpoint

@coveralls
Copy link

Pull Request Test Coverage Report for Build e0b97f8d-073c-4713-b782-a6c5f092acaf

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 79.521%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/address_transaction_controller.ex 2 80.65%
apps/block_scout_web/lib/block_scout_web/controllers/chain_controller.ex 3 86.36%
Totals Coverage Status
Change from base Build 62cf5e91-d0c8-4e59-9d44-a733b166f1fb: 0.06%
Covered Lines: 5145
Relevant Lines: 6470

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build c6d7500e-c26f-40df-af2e-517c5f043873

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.459%

Totals Coverage Status
Change from base Build 62cf5e91-d0c8-4e59-9d44-a733b166f1fb: 0.0%
Covered Lines: 5145
Relevant Lines: 6475

💛 - Coveralls

@vbaranov vbaranov merged commit 73a1780 into master Jul 25, 2019
@vbaranov vbaranov deleted the ab-fix-csv-token-transfers branch July 25, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants