add default evm version to smart contract verification #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayrat555
requested review from
zachdaniel,
pasqu4le,
vbaranov and
saneery
and removed request for
zachdaniel
Pull Request Test Coverage Report for Build 80a4a08f-74a1-44cf-b5cf-b243dfd531f2
💛 - Coveralls |
vbaranov
approved these changes
Jul 16, 2019
pasqu4le
reviewed
Jul 16, 2019
| } | ||
|
|
||
| if (evmVersion !== 'default') { | ||
| settings = Object.assign(settings, {evmVersion: evmVersion}) |
There was a problem hiding this comment.
Is the evmVersion left non-existing when default is chosen?
Should't it be set instead?
There was a problem hiding this comment.
if there is no evmVersion. default is used
pasqu4le
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a user manually has to select the evm version when verifying smart contract even if he didn't change compilation settings.
This PR adds
defaultevm version which uses the evm version that defaults to the specified Solidity version.Changelog