Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blocks cache #2075

Merged
merged 21 commits into from
Jun 7, 2019
Merged

add blocks cache #2075

merged 21 commits into from
Jun 7, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented May 31, 2019

fixes #2034

Changelog

  • add blocks cache

@coveralls
Copy link

coveralls commented May 31, 2019

Pull Request Test Coverage Report for Build 77e3d03d-e710-4d06-90e3-4c1e87b5e8dd

  • 38 of 41 (92.68%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.04%) to 80.96%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/chain.ex 7 8 87.5%
apps/explorer/lib/explorer/chain/blocks_cache.ex 28 30 93.33%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 3 88.0%
Totals Coverage Status
Change from base Build 5bebd6bc-5a5f-4073-af4f-575a6b583ce1: -0.04%
Covered Lines: 4860
Relevant Lines: 6003

💛 - Coveralls

@ayrat555 ayrat555 marked this pull request as ready for review June 3, 2019 12:47
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 it looks like cache is not invalidating. I see too many items on the first page. The screenshot is from stg server.

screencapture-eth2s-explorer-eth2s-alb-1028710543-us-east-1-elb-amazonaws-blocks-2019-06-05-09_53_26
screencapture-eth2s-explorer-eth2s-alb-1028710543-us-east-1-elb-amazonaws-blocks-2019-06-05-09_53_26-2
img

vbaranov added a commit that referenced this pull request Jun 6, 2019
@vbaranov vbaranov self-requested a review June 6, 2019 19:30
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 cache invalidation still works incorrectly. I see ~ 600 blocks on the first page on stg.

@vbaranov vbaranov merged commit e7c905b into master Jun 7, 2019
@vbaranov vbaranov deleted the ab-blocks-cache branch June 7, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store all blocks for the 1st page in ETS
6 participants