Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify query to fetch failed contract creations #1621

Merged
merged 4 commits into from
Mar 21, 2019

Conversation

ayrat555
Copy link
Contributor

Motivation

In this commit
we stopped re-fetching internal transactions when fixing failed contract creations so status field of internal transactions is not updated

Now, we will start using contract_code field of addresses to use as an indicator that we already processed that record.

Changelog

  • modify query to fetch failed contract creations

@ghost ghost assigned ayrat555 Mar 21, 2019
@ghost ghost added the in progress label Mar 21, 2019
@coveralls
Copy link

coveralls commented Mar 21, 2019

Pull Request Test Coverage Report for Build 2dd35fcb-81c3-478e-b76a-46b92cf8b93f

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.07%) to 83.44%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/indexer/lib/indexer/temporary/failed_created_addresses.ex 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
apps/indexer/lib/indexer/temporary/failed_created_addresses.ex 1 0.0%
apps/indexer/lib/indexer/internal_transaction/fetcher.ex 2 55.36%
Totals Coverage Status
Change from base Build b90c903d-5972-498e-97fd-fd6d5c8b5333: -0.07%
Covered Lines: 4318
Relevant Lines: 5175

💛 - Coveralls

@ghost ghost assigned vbaranov Mar 21, 2019
@ayrat555 ayrat555 requested a review from vbaranov March 21, 2019 11:30
@vbaranov vbaranov merged commit a188d00 into master Mar 21, 2019
@ghost ghost removed the in progress label Mar 21, 2019
@vbaranov vbaranov deleted the ab-modify-query-to-fetch-failed-contract-creation branch March 21, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants