Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test that depended on date #1537

Merged
merged 1 commit into from
Mar 7, 2019
Merged

fix test that depended on date #1537

merged 1 commit into from
Mar 7, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Mar 7, 2019

Motivation

Our ci builds fails because of this test

Changelog

  • fix test that depended on date

@ghost ghost assigned ayrat555 Mar 7, 2019
@ghost ghost added the in progress label Mar 7, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 903c8c3e-90c5-4c3f-8ccb-51241e19ab78

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 5 files lost coverage.
  • Overall coverage remained the same at 83.034%
Files with Coverage Reduction New Missed Lines %
apps/explorer/test/support/factory.ex 1 92.31%
apps/block_scout_web/test/block_scout_web/features/pages/address_contract_page.ex 1 75.0%
apps/indexer/lib/indexer/internal_transaction/fetcher.ex 2 88.89%
apps/indexer/lib/indexer/replaced_transaction/fetcher.ex 2 90.91%
apps/indexer/lib/indexer/block/catchup/fetcher.ex 4 67.86%
Totals Coverage Status
Change from base Build a3d8ab7a-859f-451a-b74f-2a9d63bb42cd: 0.0%
Covered Lines: 4204
Relevant Lines: 5063
💛 - Coveralls

@ayrat555 ayrat555 mentioned this pull request Mar 7, 2019
Merged
@vbaranov vbaranov merged commit 1c42697 into master Mar 7, 2019
@ghost ghost removed the in progress label Mar 7, 2019
@vbaranov vbaranov deleted the ab-fix-test-based-on-time branch March 7, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

@vbaranov vbaranov vbaranov approved these changes

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayrat555 @coveralls @vbaranov @zachdaniel