Skip to content

Delete Item From History #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ls-2037 opened this issue Apr 8, 2024 · 8 comments · May be fixed by #40
Open

Delete Item From History #34

ls-2037 opened this issue Apr 8, 2024 · 8 comments · May be fixed by #40

Comments

@ls-2037
Copy link

ls-2037 commented Apr 8, 2024

Is there a way to delete an item from the menu? memo-log works well for manually creating bookmarks, but then they can't be removed without editing the text file.

@uugaabuugaa
Copy link

Came here to ask for this. UOSC can delete items from playlist using Del button. Hope memo will do it as well in future updates.

@Littleweisheit
Copy link

Came here to ask for this. UOSC can delete items from playlist using Del button. Hope memo will do it as well in future updates.

Not work for me.

@Littleweisheit
Copy link

Littleweisheit commented Oct 31, 2024

script-binding uosc/playlist
图片
has delete button.
Hope add this buttoon and add "DEL" shortcut. @po5

@po5
Copy link
Owner

po5 commented Oct 31, 2024

Please refer to my comment in #7. memo's design allows for storing infinitely many entries in an efficient and thread-safe manner, working under the assumption that we only ever append to the history file. It would be trivial to add a "hide entry" function, but I am worried that is not how users would interpret it, made evident by the fact everyone in this thread is asking for a "delete" button which the design does not allow for (again, see the previous issue).
Open to ideas, as it stands the only feature I can implement would lure users into a false sense of security while the actual log file still contains the "deleted" entry (this is why I call it "hidden" instead).

@uugaabuugaa
Copy link

In my opinion having ability to simply hide entries instead of deleting is better than nothing. You can simply put a disclaimer that using the delete /hide button on entries hides that entry from memo's history from showing up in uosc but it will stay in the memohostory log file. If someone really wants to delete it from the txt file they can do so manually. For most people having the ability to hide from showing up in uosc should suffice.

@Littleweisheit
Copy link

script-binding uosc/playlist 图片 has delete button. Hope add this buttoon and add "DEL" shortcut. @po5

Change trash icon to hide icon,User will know it not deleted.

@po5
Copy link
Owner

po5 commented Oct 31, 2024

Help me understand, are the people asking for this feature using manual history? I fail to see why with the default automatic history someone would want to hide an entry without actually deleting it. What is the use case?

@uugaabuugaa
Copy link

uugaabuugaa commented Oct 31, 2024

Okay I'm a bit confused. When you say hide you mean that it won't show up when I press the history button right? Not that it'll be hidden by say a black bar or something like that. If the entry is not showing up in the history from uosc, that much is basically me being able to delete it because nobody is going into my log file to see what I'm watching including me. I get the conditional profile in mpv.conf to make it easier but still there are quite a few times I wish an entry wouldn't appear on the history that is not from specified folders. User case is basically simple convenience of being able to pretend delete within mpv without editing log file whenever I want to stop an entry from showing. I'm actually more confused why you think it doesn't have a use case when everyone is almost always watching history from mpv and never from the log file itself.
Of course I'm saying it like it's no big deal to implement it because i don't know anything about coding or how much work it might take to make it happen. So I understand not wanting to do it but surely it's a massive power to users.

@po5 po5 linked a pull request Nov 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants