You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if AIOHTTP_VERSION >= Version('3.8.0'):
# Join url with ClientSession._base_url
url = orig_self._build_url(url)
url_origin = str(url)
# Combine ClientSession headers with passed headers
if orig_self.headers:
kwargs["headers"] = orig_self._prepare_headers(kwargs.get("headers"))
else:
url_origin = url
The main change is
url = orig_self._build_url(url)
When the final url is presented, it includes the host AND path. This means our previous tests setup where we were just setting the path are starting to fail
Was this desired behaviour or is this a bug? - I'm checking in here as if it is NOT a bug I will need to set about changing my test assertions.
The text was updated successfully, but these errors were encountered:
When the final url is presented, it includes the host AND path. This means our previous tests setup where we were just setting the path are starting to fail
Exactly the same here. We used aioresponses in tests with the path only, which was kinda neat. With the 0.7.8 bump a full URL is required for tests to work.
In 0.7.8 some additional code is in play
The main change is
When the final url is presented, it includes the host AND path. This means our previous tests setup where we were just setting the path are starting to fail
Was this desired behaviour or is this a bug? - I'm checking in here as if it is NOT a bug I will need to set about changing my test assertions.
The text was updated successfully, but these errors were encountered: