Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PowerShell script doesn’t include the required $env:NODE_PATH change #6

Closed
ExE-Boss opened this issue Jul 14, 2018 · 0 comments
Closed

Comments

@ExE-Boss
Copy link
Member

ExE-Boss commented Jul 14, 2018

Turns out that the PowerShell script I added in #5 doesn’t include the $env:NODE_PATH change from 68dc8ce, as I just ported the commit from npm#27, without paying much thought to all the changes that needed to be done, and it slipped by testing, as it worked in all scenarios I threw at (except for the case when depending on dependencies which are using pluggable packages with plugins, which I discovered only after pnpm 2.11 was released), then they may break in odd ways.

The issue with this is that the PowerShell script may be run on either Windows or Linux (where Windows uses ; as PATH separators, but Unix uses :, so that will need to be handled from inside the PowerShell script)

@ExE-Boss ExE-Boss changed the title The PowerShell script doesn’t include the required NODE_PATH change The PowerShell script doesn’t include the required $env:NODE_PATH change Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant