You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of our continuous efforts to stream line the processes that support the maintenance of the Office 365 CLI, we would like to announce a change in the way that we classify pull requests that require changes.
Currently, once a pull request has been reviewed and changes are requested, we label the PR as work in progress. Whilst this has served us well till now, the problem with this approach is that the labelling of pull requests can only be performed by maintainers and it can become difficult to identify which PRs are now ready to be reviewed again after changes have been pushed, as the author of the pull request cannot change the label to signify that the PR is again ready for review.
To simplify this process and provide clearer communication, if your pull request has changes requested following a review, we will now convert the pull request to a draft stage instead of labelling as work in progress. The draft stage will signify that the pull request is in a working state and cannot be merged.
Complete the updates and push your changes as you would normally do and when you are happy for your changes to be reviewed again, change the stage of the PR to Ready for Review using the button in the pull request screen.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
As part of our continuous efforts to stream line the processes that support the maintenance of the Office 365 CLI, we would like to announce a change in the way that we classify pull requests that require changes.
Currently, once a pull request has been reviewed and changes are requested, we label the PR as
work in progress
. Whilst this has served us well till now, the problem with this approach is that the labelling of pull requests can only be performed by maintainers and it can become difficult to identify which PRs are now ready to be reviewed again after changes have been pushed, as the author of the pull request cannot change the label to signify that the PR is again ready for review.To simplify this process and provide clearer communication, if your pull request has changes requested following a review, we will now convert the pull request to a
draft
stage instead of labelling aswork in progress
. Thedraft
stage will signify that the pull request is in a working state and cannot be merged.Complete the updates and push your changes as you would normally do and when you are happy for your changes to be reviewed again, change the stage of the PR to
Ready for Review
using the button in the pull request screen.Garry, Waldek, Velin and Appie
More information
Beta Was this translation helpful? Give feedback.
All reactions