Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding data location support to Provisioning (Multi-geo location scenario) #643

Open
luismanez opened this issue Oct 22, 2024 · 0 comments

Comments

@luismanez
Copy link

luismanez commented Oct 22, 2024

We have the need to support data location when provisioning. When provisioning Team Sites, as they are created using Graph API, if the tenant has enabled Multi-region, the SharePoint site is created in the default location. PnP Framework allows to create TeamSite in a specific location in some of their methods, like:

UnifiedGroupsUtility.CreateUnifiedGroup(
        displayName: "PnP Team",
        description: "PnP Team",
        mailNickname: "pnp-team",
        accessToken: token,
        preferredDataLocation: PnP.Framework.Enums.Office365Geography.NAM,
        owners: ["[email protected]"],
        members: ["[email protected]"],
        groupLogoPath: null
    );

However, when using the PnP Schema, there is no way to pass that preferredDataLocation from the XML to the ObjectHierarchySequenceSites Handler.

We’ve been doing some tests, and we think we can create a Pull Request to add that support (here, and in the PnP Framework repo), but we want to double check first if this repo is still maintained, as it hasn’t changed in 2 years. Also cos the merge requires some coordination between both PnP repos.

Disclaimer: For now, it would only support XML templates (not JSON), only the TeamSite node, and only when Provisioning, not when extracting the template.

Basically the changes are:

  • in the TeamSiteCollection class
Pasted Graphic
  • In the Provisioning handler:
image
  • and then, the XML would be something like:
Pasted Graphic 1

Please, can someone in the PnP Team to confirm they’re happy with us doing the PR?

Many thanks

/cc @PaoloPia @VesaJuvonen @patrick-rodgers (sorry for the direct mention :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant