Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker container TODO #5

Open
tashrifbillah opened this issue Oct 21, 2020 · 0 comments
Open

Docker container TODO #5

tashrifbillah opened this issue Oct 21, 2020 · 0 comments
Labels

Comments

@tashrifbillah
Copy link
Contributor

Currently, all environments are set up in /home/pnlbwh/.bashrc through a bunch of source. That way, we didn't have to explicitly define variables like CONDA_PREFIX. This shortcut puts an overhead on the user about providing any command to run within " " such as:

docker run --rm tbillah/pnlpipe "nifti_atlas --help"

However, if singularity like environment definition is used, we should not have to enclose within " ":
https://github.com/pnlbwh/pnlpipe-containers/blob/master/Singularity.pnlpipe#L88

Impact of the overhead should be minor because not a lot of users may have docker capability. But we should fix it in the future.

@tashrifbillah tashrifbillah added the enhancement New feature or request label Oct 21, 2020
@tashrifbillah tashrifbillah added backlog and removed enhancement New feature or request labels Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant