onPinch breaking on control + scroll

[Khush08]

Describe the bug

The onPinch gesture starts breaking while using control + scroll. The movement property on the onPinch state has a NaN value at the Oth index. The onPinch gesture completely stops working after that

Sandbox or Video
https://codesandbox.io/s/fancy-rgb-x959zf?file=/src/App.js

pinch.mov

Steps to reproduce - Try zooming the blue box using control + mouse scroll wheel multiple times

Information:

• Use Gesture version: 10.2.23
• Device: Macbook Pro
• OS: MacOS
• Browser: Chrome

[dbismut]

I tried and can't reproduce. What mouse are you using? Not sure what I'm supposed to look at in the video btw.

[Khush08]

I am using Logitech M650. In the video I wanted to highlight that the movement[0] is assigned a NaN value on control + scroll. Once the 0th index of movement is assigned NaN, the gesture stops working

[Khush08]

Btw it is not mouse specific

[dbismut]

Hm in your code there is supposed to be an alert when the movement is NaN... I don't see it in the video.

[Khush08]

Hmmm, let me share a new video

use-ges-pinch.mov

[johannes-lindgren]

I am experiencing the same issue on a similar setup:

Use Gesture version: 10.3.1
Device: Macbook Pro
OS: MacOS
Browser: Chrome
Mouse: Logitech Master MX 3

When scrolling down (and vice versa for scrolling up), state.movement[0] grows incredibly large (>10^100) until it becomes NaN. It can also flip signs between callbacks, which means that even if you clamp the value, the zoom can swap between zoomed-out and zoomed-in very fast, causing flicker.

[johannes-lindgren]

In the following screenshot, I log the state.movement[0], and scroll slowly. Notice how it alternates between positive and negative values:

In the next screenshot, I have been scrolling fast. Notice how large the values are:

If I keep scrolling, I encounter NaN:

I think it has to do with scroll acceleration on MacOS:

• https://discussions.apple.com/thread/8597049?sortBy=rank
• https://superuser.com/questions/200660/how-do-you-disable-mouse-scroll-wheel-acceleration-in-mac-os

When scrolling with the Logitech M3 mouse, I get very large deltaY, around 380, while the trackpad gives values around 1. This value is multiplied to the movement, which means that it grows exponentially, with an exponent that is about 400 times larger than normal.

If so, one could claim that this is not a bug in the library. On the other hand, if you use various tools like Miro and Figma, you'll notice that they've somehow solved it.

Or perhaps I am using the movement incorrectly?

[johannes-lindgren]

@Khush08, I can avoid the worst effects (Infinites and NaN) by including setting scaleBounds in useGesture's second argument:

      pinch: {
        preventDefault: true,
        scaleBounds: { min: 0.5, max: 2 },
      },