Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useVideoTexture enhancements #2126

Merged
merged 1 commit into from
Oct 18, 2024
Merged

useVideoTexture enhancements #2126

merged 1 commit into from
Oct 18, 2024

Conversation

abernier
Copy link
Member

@abernier abernier commented Oct 18, 2024

Why

What

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 10:34am

Copy link

codesandbox-ci bot commented Oct 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@netgfx
Copy link
Contributor

netgfx commented Oct 18, 2024

@abernier Hello, is it possible to also showcase the HLS capabilities as well? I have an example on codesanbox that showcases it https://codesandbox.io/p/sandbox/drei-hls-usevideotexture-4syd5j


export const VideoTextureSt4 = {
args: {
src: 'https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8', // m3u8 file from: https://hlsjs.video-dev.org/demo/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a story with HLS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc updated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplified / dryed types and other enhancements

@abernier
Copy link
Member Author

abernier commented Oct 18, 2024

t possible to also showcase the HLS capabilities as well? I have

image

I've just added a story ;)

@abernier abernier self-assigned this Oct 18, 2024
@abernier abernier marked this pull request as ready for review October 18, 2024 10:43
@abernier abernier merged commit 5b1d215 into master Oct 18, 2024
5 checks passed
Copy link

🎉 This PR is included in version 9.114.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants