Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clouds rename conflicting attribute #2080

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

vis-prime
Copy link
Contributor

Why

As noted in pmndrs/drei-vanilla#71 While viewing Clouds on Android, the error Name conflicts between an uniform and an attribute: opacity_ shows up and the cloud component does not load.

Screenshot 2024-08-29 195015

What

  • to fix, the opacity attribute is renamed to cloudOpacity
  • some esLint fixes

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

Copy link

vercel bot commented Aug 29, 2024

@vis-prime is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codesandbox-ci bot commented Aug 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vis-prime vis-prime marked this pull request as ready for review August 29, 2024 15:04
@CodyJasonBennett CodyJasonBennett merged commit 53a7b32 into pmndrs:master Aug 30, 2024
2 of 3 checks passed
Copy link

🎉 This PR is included in version 9.111.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vis-prime vis-prime deleted the clouds-attribute-rename branch August 30, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants