Block interactions are not executed when sneaking

[ColinHDev]

Issue description

• Expected result: In Vanilla, it does not matter if you sneak while interacting with bone meal on a grass block. Flowers, grass, etc. should grow either way.
• Actual result: All block interactions are cancelled when the player is sneaking due to this. Therefore, you can't use bone meal when sneaking.

Steps to reproduce the issue

1. Take some bone meal
2. Sneak
3. Interact with grass blocks

OS and versions

• PocketMine-MP: 4.6.0 and 5.0.0
  Tested on both test.pmmp.io:19133 and test.pmmp.io:19132
• PHP: 8.0.19
• Using JIT: no
• Server OS: linux
• Game version: Win10

Plugins

---

Crashdump, backtrace or other files

---

[dktapps]

This sounds like a bug in vanilla to me.

[ColinHDev]

That's what I also thought at first. But it's the same in Java Edition. And it's not limited to bone meal. It's the same case with "shovels and pathways" and "compass and lodestones" (although that's not implemented in PM anyway).

I've dug a bit around this in Java Edition's source (I'm not that experienced with IDA and more familiar with Java). Both Java and PM have use methods in item and block classes and those of the block classes are only called if the player is not sneaking. But, unlike PM, they implemented the fertilizer or "shovel" logic not in the GrassBlock class like PM, but in the respective item class, which would explain this behaviour.

[dktapps]

If this is correct, I'd also expect paintings, spawn eggs and other items to work while sneaking too.

[ColinHDev]

It does. While sneaking, you can also spawn mobs with spawn eggs or place e.g. either paintings or item frames.

[IvanCraft623]

Happens thanks to this line.

This is also causing players to be unable to interact with copper doors/trapdoors to wax/unwax them or remove oxidation (They need to be sneaking to do this)

Change the line to

if((!$player->isSneaking() || $item->isNull() || !$item instanceof ItemBlock) && $blockClicked->onInteract($item, $face, $clickVector, $player, $returnedItems)){

seems to fixe it.

[dktapps]

In minor-next it should be enough to change this:

PocketMine-MP/src/world/World.php

Line 2177 in a396233

$ev->setUseItem(false);

Fixing the other stuff like shovels on grass will be a bit more awkward though.