JsonNbtParser: fixed TypeError being thrown when mixing ListTag value types

Author: dktapps

src/JsonNbtParser.php

@@ -78,10 +78,15 @@ private static function parseList(BinaryStream $stream) : ListTag{
 		if(self::skipWhitespace($stream, "]")){
 			while(!$stream->feof()){
 				try{
-					$retval->push(self::readValue($stream));
+					$value = self::readValue($stream);
 				}catch(InvalidTagValueException $e){
 					throw new NbtDataException("Data error: " . $e->getMessage());
 				}
+				$expectedType = $retval->getTagType();
+				if($expectedType !== NBT::TAG_End && $expectedType !== $value->getType()){
+					throw new NbtDataException("Data error: lists can only contain one type of value");
+				}
+				$retval->push($value);
 				if(self::readBreak($stream, "]")){
 					return $retval;
 				}

tests/phpunit/JsonNbtParserTest.php

@@ -69,7 +69,7 @@ public function testEmptyList() : void{
 	}
 
 	public function testMixedList() : void{
-		$this->expectException(\TypeError::class); //TODO: throwing an engine level error on userdata is very bad ...
+		$this->expectExceptionMessage("lists can only contain one type of value");
 		JsonNbtParser::parseJson("{TestList:[1f, string2, 3b]}");
 	}